6ec53f5d48
Every project page displays a navigation menu that in turn displays the number of open issues and merge requests. This means that for every project page we run two COUNT(*) queries, each taking up roughly 30 milliseconds on GitLab.com. By caching these numbers and refreshing them whenever necessary we can reduce loading times of all these pages by up to roughly 60 milliseconds. The number of open issues does not include confidential issues. This is a trade-off to keep the code simple and to ensure refreshing the data only needs 2 COUNT(*) queries instead of 3. A downside is that if a project only has 5 confidential issues the counter will be set to 0. Because we now have 3 similar counting service classes the code previously used in Projects::ForksCountService has mostly been moved to Projects::CountService, which in turn is reused by the various service classes. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36622
65 lines
2 KiB
Ruby
65 lines
2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Issues::ReopenService do
|
|
let(:project) { create(:project) }
|
|
let(:issue) { create(:issue, :closed, project: project) }
|
|
|
|
describe '#execute' do
|
|
context 'when user is not authorized to reopen issue' do
|
|
before do
|
|
guest = create(:user)
|
|
project.team << [guest, :guest]
|
|
|
|
perform_enqueued_jobs do
|
|
described_class.new(project, guest).execute(issue)
|
|
end
|
|
end
|
|
|
|
it 'does not reopen the issue' do
|
|
expect(issue).to be_closed
|
|
end
|
|
end
|
|
|
|
context 'when user is authrized to reopen issue' do
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
project.team << [user, :master]
|
|
end
|
|
|
|
it 'invalidates counter cache for assignees' do
|
|
issue.assignees << user
|
|
expect_any_instance_of(User).to receive(:invalidate_issue_cache_counts)
|
|
|
|
described_class.new(project, user).execute(issue)
|
|
end
|
|
|
|
it 'refreshes the number of opened issues' do
|
|
service = described_class.new(project, user)
|
|
|
|
expect { service.execute(issue) }
|
|
.to change { project.open_issues_count }.from(0).to(1)
|
|
end
|
|
|
|
context 'when issue is not confidential' do
|
|
it 'executes issue hooks' do
|
|
expect(project).to receive(:execute_hooks).with(an_instance_of(Hash), :issue_hooks)
|
|
expect(project).to receive(:execute_services).with(an_instance_of(Hash), :issue_hooks)
|
|
|
|
described_class.new(project, user).execute(issue)
|
|
end
|
|
end
|
|
|
|
context 'when issue is confidential' do
|
|
it 'executes confidential issue hooks' do
|
|
issue = create(:issue, :confidential, :closed, project: project)
|
|
|
|
expect(project).to receive(:execute_hooks).with(an_instance_of(Hash), :confidential_issue_hooks)
|
|
expect(project).to receive(:execute_services).with(an_instance_of(Hash), :confidential_issue_hooks)
|
|
|
|
described_class.new(project, user).execute(issue)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|