be7ab1f2bc
Fix attr reader to force the intended values for source and target shas
## What does this MR do?
When importing a pull request from GitHub, the old and new branches may no longer actually exist by those names, but we need to recreate the merge
request diff with the right source and target shas. We use these `target_branch_sha` and `source_branch_sha` attributes to force these to the intended values. But the reader methods were always looking up to the target/source branch head instead of check if these values was previously set, this MR applies a memoization pattern to both of them.
## Are there points in the code the reviewer needs to double check?
This [commit](
|
||
|---|---|---|
| .. | ||
| config | ||
| controllers | ||
| factories | ||
| features | ||
| finders | ||
| fixtures | ||
| helpers | ||
| initializers | ||
| javascripts | ||
| lib | ||
| mailers | ||
| models | ||
| requests | ||
| routing | ||
| services | ||
| support | ||
| tasks/gitlab | ||
| uploaders | ||
| views | ||
| workers | ||
| factories_spec.rb | ||
| rails_helper.rb | ||
| simplecov_env.rb | ||
| spec_helper.rb | ||
| teaspoon_env.rb | ||