kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/services
History
Fatih Acet c49517a004 Merge branch 'fix/persistent-import-data' into 'master' 
Fix import_data being saved as a result of an invalid import_url

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/19479

Seem that in all cases the `import_url` was an empty string. The `import_url` is now validated correctly and no longer creates the `import_data`even if it fails validation. <= Should cover cases 1, 3, and 4 of https://gitlab.com/gitlab-org/gitlab-ce/issues/19479#note_13005276

Also, it now rescues from all exceptions when importing from a URL, so we make sure the `import_status` is failed after that. Covers case 2 of https://gitlab.com/gitlab-org/gitlab-ce/issues/19479#note_13005276

See merge request !5206
 		2016-07-14 14:50:34 +00:00
..
auth Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
ci Merge remote-tracking branch 'upstream/master' into feature/runner-lock-on-project 2016-06-17 19:52:55 +08:00
commits Revert "Merge branch '18193-developers-can-merge' into 'master' " 2016-07-13 13:57:30 -05:00
files Revert "Merge branch '18193-developers-can-merge' into 'master' " 2016-07-13 13:57:30 -05:00
groups Address feedback 2016-03-22 00:09:20 +01:00
issues Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
members Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member 2016-06-18 06:06:34 +02:00
merge_requests Revert "Merge branch '18193-developers-can-merge' into 'master' " 2016-07-13 13:57:30 -05:00
milestones Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
notes Automatically update diff note positions when MR is pushed to 2016-07-06 18:51:00 -04:00
oauth2 Enable Style/EmptyLinesAroundAccessModifier rubocop cop 2016-06-03 10:34:20 +02:00
projects Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into fix/persistent-import-data 2016-07-13 13:44:07 +02:00
search Restrict access to confidential issues on search results 2016-03-17 20:55:59 -03:00
wiki_pages Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
audit_event_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
base_service.rb Tweaks, refactoring, and specs 2016-03-20 21:04:07 +01:00
compare_service.rb Remove unused argument to CompareService#execute 2016-07-08 13:53:17 +01:00
create_branch_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
create_commit_builds_service.rb Remove reduntant method for building pipeline builds 2016-06-15 14:12:25 +02:00
create_deployment_service.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
create_release_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
create_snippet_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
create_spam_log_service.rb Support Akismet spam checking for creation of issues via API 2016-02-02 11:25:44 -02:00
create_tag_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
delete_branch_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
delete_tag_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
delete_user_service.rb Clearify who deletes the user 2016-03-15 21:09:25 +01:00
destroy_group_service.rb Add ability to delete a user with force 2016-03-15 21:09:25 +01:00
event_create_service.rb Create a "destroyed Milestone" event and keep Milestone events around in the DB 2015-09-15 05:51:11 -07:00
git_hooks_service.rb Better message for git hooks and file locks 2016-07-04 15:31:49 +03:00
git_push_service.rb Revert "Merge branch '18193-developers-can-merge' into 'master' " 2016-07-13 13:57:30 -05:00
git_tag_push_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
gravatar_service.rb Add support for HiDPI displays in gravatar service 2015-09-26 20:53:16 +02:00
issuable_base_service.rb Spec label add / delete in UpdateService 2016-06-03 17:14:23 -05:00
notification_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
repair_ldap_blocked_user_service.rb Code style fixes and some code simplified 2016-01-08 16:26:04 -02:00
system_hooks_service.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
system_note_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
test_hook_service.rb Added X-GitLab-Event header for web hooks 2015-05-08 16:49:03 +03:00
todo_service.rb Ensure logged-out users can't see private refs 2016-06-30 16:36:10 +01:00
update_release_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00
update_snippet_service.rb Services: code style fixes, minor refactoring 2016-07-06 20:58:43 +03:00