3fbd48e127
commit 10456b1e9240886432f565dd17689080bbb133b9
Merge: 312c1a9bdf8 a5f4627857
Author: Shinya Maeda <shinya@gitlab.com>
Date: Thu Nov 29 14:33:21 2018 +0900
Merge branch 'master-ce' into add-counter-for-trace-chunks
commit 312c1a9bdf8efc45c3fed5ff50f05cc589bbb4ed
Author: Shinya Maeda <shinya@gitlab.com>
Date: Wed Nov 28 20:06:18 2018 +0900
Fix coding offence
commit e397cc2ccc1b2cf7f8b3558b8fa81fe2aa0ab366
Author: Shinya Maeda <shinya@gitlab.com>
Date: Wed Nov 28 14:40:24 2018 +0900
Fix tracking archive failure
25 lines
808 B
Ruby
25 lines
808 B
Ruby
# frozen_string_literal: true
|
|
|
|
module Ci
|
|
class ArchiveTraceService
|
|
def execute(job)
|
|
job.trace.archive!
|
|
rescue ::Gitlab::Ci::Trace::AlreadyArchivedError
|
|
# It's already archived, thus we can safely ignore this exception.
|
|
rescue => e
|
|
archive_error(e, job)
|
|
end
|
|
|
|
private
|
|
|
|
def failed_archive_counter
|
|
@failed_archive_counter ||= Gitlab::Metrics.counter(:job_trace_archive_failed_total, "Counter of failed attempts of trace archiving")
|
|
end
|
|
|
|
def archive_error(error, job)
|
|
failed_archive_counter.increment
|
|
Gitlab::Sentry.track_exception(error, issue_url: 'https://gitlab.com/gitlab-org/gitlab-ce/issues/51502', extra: { job_id: job.id })
|
|
Rails.logger.error "Failed to archive trace. id: #{job.id} message: #{error.message}"
|
|
end
|
|
end
|
|
end
|