37b17fa61a
Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
89 lines
2.6 KiB
Ruby
89 lines
2.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe AwardEmojis::DestroyService do
|
|
set(:user) { create(:user) }
|
|
set(:awardable) { create(:note) }
|
|
set(:project) { awardable.project }
|
|
let(:name) { 'thumbsup' }
|
|
let!(:award_from_other_user) do
|
|
create(:award_emoji, name: name, awardable: awardable, user: create(:user))
|
|
end
|
|
subject(:service) { described_class.new(awardable, name, user) }
|
|
|
|
describe '#execute' do
|
|
shared_examples_for 'a service that does not authorize the user' do |error:|
|
|
it 'does not remove the emoji' do
|
|
expect { service.execute }.not_to change { AwardEmoji.count }
|
|
end
|
|
|
|
it 'returns an error state' do
|
|
result = service.execute
|
|
|
|
expect(result[:status]).to eq(:error)
|
|
expect(result[:http_status]).to eq(:forbidden)
|
|
end
|
|
|
|
it 'returns a nil award' do
|
|
result = service.execute
|
|
|
|
expect(result).to have_key(:award)
|
|
expect(result[:award]).to be_nil
|
|
end
|
|
|
|
it 'returns the error' do
|
|
result = service.execute
|
|
|
|
expect(result[:message]).to eq(error)
|
|
expect(result[:errors]).to eq([error])
|
|
end
|
|
end
|
|
|
|
context 'when user is not authorized' do
|
|
it_behaves_like 'a service that does not authorize the user',
|
|
error: 'User cannot destroy emoji on the awardable'
|
|
end
|
|
|
|
context 'when the user is authorized' do
|
|
before do
|
|
project.add_developer(user)
|
|
end
|
|
|
|
context 'when user has not awarded an emoji to the awardable' do
|
|
let!(:award_from_user) { create(:award_emoji, name: name, user: user) }
|
|
|
|
it_behaves_like 'a service that does not authorize the user',
|
|
error: 'User has not awarded emoji of type thumbsup on the awardable'
|
|
end
|
|
|
|
context 'when user has awarded an emoji to the awardable' do
|
|
let!(:award_from_user) { create(:award_emoji, name: name, awardable: awardable, user: user) }
|
|
|
|
it 'removes the emoji' do
|
|
expect { service.execute }.to change { AwardEmoji.count }.by(-1)
|
|
end
|
|
|
|
it 'returns a success status' do
|
|
result = service.execute
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
end
|
|
|
|
it 'returns no errors' do
|
|
result = service.execute
|
|
|
|
expect(result).not_to have_key(:error)
|
|
expect(result).not_to have_key(:errors)
|
|
end
|
|
|
|
it 'returns the destroyed award' do
|
|
result = service.execute
|
|
|
|
expect(result[:award]).to eq(award_from_user)
|
|
expect(result[:award]).to be_destroyed
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|