1236 lines
46 KiB
Ruby
1236 lines
46 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe 'Rack Attack global throttles', :use_clean_rails_memory_store_caching do
|
|
include RackAttackSpecHelpers
|
|
|
|
let(:settings) { Gitlab::CurrentSettings.current_application_settings }
|
|
|
|
# Start with really high limits and override them with low limits to ensure
|
|
# the right settings are being exercised
|
|
let(:settings_to_set) do
|
|
{
|
|
throttle_unauthenticated_api_requests_per_period: 100,
|
|
throttle_unauthenticated_api_period_in_seconds: 1,
|
|
throttle_unauthenticated_requests_per_period: 100,
|
|
throttle_unauthenticated_period_in_seconds: 1,
|
|
throttle_authenticated_api_requests_per_period: 100,
|
|
throttle_authenticated_api_period_in_seconds: 1,
|
|
throttle_authenticated_web_requests_per_period: 100,
|
|
throttle_authenticated_web_period_in_seconds: 1,
|
|
throttle_authenticated_protected_paths_request_per_period: 100,
|
|
throttle_authenticated_protected_paths_in_seconds: 1,
|
|
throttle_unauthenticated_packages_api_requests_per_period: 100,
|
|
throttle_unauthenticated_packages_api_period_in_seconds: 1,
|
|
throttle_authenticated_packages_api_requests_per_period: 100,
|
|
throttle_authenticated_packages_api_period_in_seconds: 1,
|
|
throttle_authenticated_git_lfs_requests_per_period: 100,
|
|
throttle_authenticated_git_lfs_period_in_seconds: 1,
|
|
throttle_unauthenticated_files_api_requests_per_period: 100,
|
|
throttle_unauthenticated_files_api_period_in_seconds: 1,
|
|
throttle_authenticated_files_api_requests_per_period: 100,
|
|
throttle_authenticated_files_api_period_in_seconds: 1,
|
|
throttle_unauthenticated_deprecated_api_requests_per_period: 100,
|
|
throttle_unauthenticated_deprecated_api_period_in_seconds: 1,
|
|
throttle_authenticated_deprecated_api_requests_per_period: 100,
|
|
throttle_authenticated_deprecated_api_period_in_seconds: 1
|
|
}
|
|
end
|
|
|
|
let(:request_method) { 'GET' }
|
|
let(:requests_per_period) { 1 }
|
|
let(:period_in_seconds) { 10000 }
|
|
let(:period) { period_in_seconds.seconds }
|
|
|
|
include_context 'rack attack cache store'
|
|
|
|
describe 'unauthenticated API requests' do
|
|
it_behaves_like 'rate-limited unauthenticated requests' do
|
|
let(:throttle_name) { 'throttle_unauthenticated_api' }
|
|
let(:throttle_setting_prefix) { 'throttle_unauthenticated_api' }
|
|
let(:url_that_does_not_require_authentication) { '/api/v4/projects' }
|
|
let(:url_that_is_not_matched) { '/users/sign_in' }
|
|
end
|
|
end
|
|
|
|
describe 'unauthenticated web requests' do
|
|
it_behaves_like 'rate-limited unauthenticated requests' do
|
|
let(:throttle_name) { 'throttle_unauthenticated_web' }
|
|
let(:throttle_setting_prefix) { 'throttle_unauthenticated' }
|
|
let(:url_that_does_not_require_authentication) { '/users/sign_in' }
|
|
let(:url_that_is_not_matched) { '/api/v4/projects' }
|
|
end
|
|
end
|
|
|
|
describe 'API requests authenticated with personal access token', :api do
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:token) { create(:personal_access_token, user: user) }
|
|
let_it_be(:other_user) { create(:user) }
|
|
let_it_be(:other_user_token) { create(:personal_access_token, user: other_user) }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_api' }
|
|
let(:api_partial_url) { '/todos' }
|
|
|
|
context 'with the token in the query string' do
|
|
let(:request_args) { [api(api_partial_url, personal_access_token: token), {}] }
|
|
let(:other_user_request_args) { [api(api_partial_url, personal_access_token: other_user_token), {}] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the OAuth headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in basic auth' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, basic_auth_headers(user, token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, basic_auth_headers(other_user, other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with a read_api scope' do
|
|
before do
|
|
token.update!(scopes: ['read_api'])
|
|
other_user_token.update!(scopes: ['read_api'])
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the OAuth headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'API requests authenticated with OAuth token', :api do
|
|
let(:user) { create(:user) }
|
|
let(:application) { Doorkeeper::Application.create!(name: "MyApp", redirect_uri: "https://app.com", owner: user) }
|
|
let(:token) { Doorkeeper::AccessToken.create!(application_id: application.id, resource_owner_id: user.id, scopes: "api") }
|
|
|
|
let(:other_user) { create(:user) }
|
|
let(:other_user_application) { Doorkeeper::Application.create!(name: "MyApp", redirect_uri: "https://app.com", owner: other_user) }
|
|
let(:other_user_token) { Doorkeeper::AccessToken.create!(application_id: application.id, resource_owner_id: other_user.id, scopes: "api") }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_api' }
|
|
let(:api_partial_url) { '/todos' }
|
|
|
|
context 'with the token in the query string' do
|
|
let(:request_args) { [api(api_partial_url, oauth_access_token: token), {}] }
|
|
let(:other_user_request_args) { [api(api_partial_url, oauth_access_token: other_user_token), {}] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with a read_api scope' do
|
|
let(:read_token) { Doorkeeper::AccessToken.create!(application_id: application.id, resource_owner_id: user.id, scopes: "read_api") }
|
|
let(:other_user_read_token) { Doorkeeper::AccessToken.create!(application_id: other_user_application.id, resource_owner_id: other_user.id, scopes: "read_api") }
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(read_token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, oauth_token_headers(other_user_read_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
end
|
|
|
|
describe '"web" (non-API) requests authenticated with RSS token' do
|
|
let(:user) { create(:user) }
|
|
let(:other_user) { create(:user) }
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_web' }
|
|
|
|
context 'with the token in the query string' do
|
|
let(:request_args) { [rss_url(user), params: nil] }
|
|
let(:other_user_request_args) { [rss_url(other_user), params: nil] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
end
|
|
|
|
describe 'web requests authenticated with regular login' do
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_web' }
|
|
let(:user) { create(:user) }
|
|
let(:url_that_requires_authentication) { '/dashboard/snippets' }
|
|
|
|
it_behaves_like 'rate-limited web authenticated requests'
|
|
end
|
|
|
|
describe 'protected paths' do
|
|
let(:request_method) { 'POST' }
|
|
|
|
context 'unauthenticated requests' do
|
|
let(:protected_path_that_does_not_require_authentication) do
|
|
'/users/sign_in'
|
|
end
|
|
|
|
let(:post_params) { { user: { login: 'username', password: 'password' } } }
|
|
|
|
def do_request
|
|
post protected_path_that_does_not_require_authentication, params: post_params
|
|
end
|
|
|
|
before do
|
|
settings_to_set[:throttle_protected_paths_requests_per_period] = requests_per_period # 1
|
|
settings_to_set[:throttle_protected_paths_period_in_seconds] = period_in_seconds # 10_000
|
|
end
|
|
|
|
context 'when protected paths throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_protected_paths_enabled] = false
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'allows requests over the rate limit' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when protected paths throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_protected_paths_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { post protected_path_that_does_not_require_authentication, params: post_params }
|
|
end
|
|
|
|
it_behaves_like 'tracking when dry-run mode is set' do
|
|
let(:throttle_name) { 'throttle_unauthenticated_protected_paths' }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'API requests authenticated with personal access token', :api do
|
|
let(:user) { create(:user) }
|
|
let(:token) { create(:personal_access_token, user: user) }
|
|
let(:other_user) { create(:user) }
|
|
let(:other_user_token) { create(:personal_access_token, user: other_user) }
|
|
let(:throttle_setting_prefix) { 'throttle_protected_paths' }
|
|
let(:api_partial_url) { '/user/emails' }
|
|
|
|
let(:protected_paths) do
|
|
[
|
|
'/api/v4/user/emails'
|
|
]
|
|
end
|
|
|
|
before do
|
|
settings_to_set[:protected_paths] = protected_paths
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
context 'with the token in the query string' do
|
|
let(:request_args) { [api(api_partial_url, personal_access_token: token), {}] }
|
|
let(:other_user_request_args) { [api(api_partial_url, personal_access_token: other_user_token), {}] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
end
|
|
|
|
describe 'web requests authenticated with regular login' do
|
|
let(:throttle_setting_prefix) { 'throttle_protected_paths' }
|
|
let(:user) { create(:user) }
|
|
let(:url_that_requires_authentication) { '/users/confirmation' }
|
|
|
|
let(:protected_paths) do
|
|
[
|
|
url_that_requires_authentication
|
|
]
|
|
end
|
|
|
|
before do
|
|
settings_to_set[:protected_paths] = protected_paths
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it_behaves_like 'rate-limited web authenticated requests'
|
|
end
|
|
end
|
|
|
|
describe 'Packages API' do
|
|
let(:request_method) { 'GET' }
|
|
|
|
context 'unauthenticated' do
|
|
let_it_be(:project) { create(:project, :public) }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_unauthenticated_packages_api' }
|
|
let(:packages_path_that_does_not_require_authentication) { "/api/v4/projects/#{project.id}/packages/conan/v1/ping" }
|
|
|
|
def do_request
|
|
get packages_path_that_does_not_require_authentication
|
|
end
|
|
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_packages_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_packages_api_period_in_seconds] = period_in_seconds
|
|
end
|
|
|
|
context 'when unauthenticated packages api throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_packages_api_enabled] = false
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'allows requests over the rate limit' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the unauthenticated api rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated web throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_web_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_web_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_web_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores unauthenticated web throttle' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated packages api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_packages_api_requests_per_period] = requests_per_period # 1
|
|
settings_to_set[:throttle_unauthenticated_packages_api_period_in_seconds] = period_in_seconds # 10_000
|
|
settings_to_set[:throttle_unauthenticated_packages_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
|
|
context 'when unauthenticated api throttle is lower' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_api_requests_per_period] = 0
|
|
settings_to_set[:throttle_unauthenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores unauthenticated api throttle' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'tracking when dry-run mode is set' do
|
|
let(:throttle_name) { 'throttle_unauthenticated_packages_api' }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'authenticated', :api do
|
|
let_it_be(:project) { create(:project, :internal) }
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:token) { create(:personal_access_token, user: user) }
|
|
let_it_be(:other_user) { create(:user) }
|
|
let_it_be(:other_user_token) { create(:personal_access_token, user: other_user) }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_packages_api' }
|
|
let(:api_partial_url) { "/projects/#{project.id}/packages/conan/v1/ping" }
|
|
|
|
before do
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
context 'with the token in the query string' do
|
|
let(:request_args) { [api(api_partial_url, personal_access_token: token), {}] }
|
|
let(:other_user_request_args) { [api(api_partial_url, personal_access_token: other_user_token), {}] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'precedence over authenticated api throttle' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_packages_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_packages_api_period_in_seconds] = period_in_seconds
|
|
end
|
|
|
|
def do_request
|
|
get api(api_partial_url, personal_access_token: token)
|
|
end
|
|
|
|
context 'when authenticated packages api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_packages_api_enabled] = true
|
|
end
|
|
|
|
context 'when authenticated api throttle is lower' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_api_requests_per_period] = 0
|
|
settings_to_set[:throttle_authenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores authenticated api throttle' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when authenticated packages api throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_packages_api_enabled] = false
|
|
end
|
|
|
|
context 'when authenticated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the authenticated api rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'dependency proxy' do
|
|
include DependencyProxyHelpers
|
|
|
|
let_it_be_with_reload(:group) { create(:group) }
|
|
let_it_be_with_reload(:other_group) { create(:group) }
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:other_user) { create(:user) }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_web' }
|
|
let(:jwt_token) { build_jwt(user) }
|
|
let(:other_jwt_token) { build_jwt(other_user) }
|
|
let(:request_args) { [path, headers: jwt_token_authorization_headers(jwt_token)] }
|
|
let(:other_user_request_args) { [other_path, headers: jwt_token_authorization_headers(other_jwt_token)] }
|
|
|
|
before do
|
|
group.add_owner(user)
|
|
other_group.add_owner(other_user)
|
|
|
|
allow(Gitlab.config.dependency_proxy)
|
|
.to receive(:enabled).and_return(true)
|
|
token_response = { status: :success, token: 'abcd1234' }
|
|
allow_next_instance_of(DependencyProxy::RequestTokenService) do |instance|
|
|
allow(instance).to receive(:execute).and_return(token_response)
|
|
end
|
|
end
|
|
|
|
context 'getting a manifest' do
|
|
let_it_be(:manifest) { create(:dependency_proxy_manifest) }
|
|
|
|
let(:path) { "/v2/#{group.path}/dependency_proxy/containers/alpine/manifests/latest" }
|
|
let(:other_path) { "/v2/#{other_group.path}/dependency_proxy/containers/alpine/manifests/latest" }
|
|
let(:pull_response) { { status: :success, manifest: manifest, from_cache: false } }
|
|
let(:head_response) { { status: :success } }
|
|
|
|
before do
|
|
allow_next_instance_of(DependencyProxy::FindCachedManifestService) do |instance|
|
|
allow(instance).to receive(:execute).and_return(pull_response)
|
|
end
|
|
allow_next_instance_of(DependencyProxy::HeadManifestService) do |instance|
|
|
allow(instance).to receive(:execute).and_return(head_response)
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'getting a blob' do
|
|
let_it_be(:blob) { create(:dependency_proxy_blob) }
|
|
let_it_be(:other_blob) { create(:dependency_proxy_blob) }
|
|
|
|
let(:path) { "/v2/#{blob.group.path}/dependency_proxy/containers/alpine/blobs/sha256:a0d0a0d46f8b52473982a3c466318f479767577551a53ffc9074c9fa7035982e" }
|
|
let(:other_path) { "/v2/#{other_blob.group.path}/dependency_proxy/containers/alpine/blobs/sha256:a0d0a0d46f8b52473982a3c466318f479767577551a53ffc9074c9fa7035982e" }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
end
|
|
|
|
describe 'authenticated git lfs requests', :api do
|
|
let_it_be(:project) { create(:project, :internal) }
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:token) { create(:personal_access_token, user: user) }
|
|
let_it_be(:other_user) { create(:user) }
|
|
let_it_be(:other_user_token) { create(:personal_access_token, user: other_user) }
|
|
|
|
let(:request_method) { 'GET' }
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_git_lfs' }
|
|
let(:git_lfs_url) { "/#{project.full_path}.git/info/lfs/locks" }
|
|
|
|
before do
|
|
allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
context 'with regular login' do
|
|
let(:url_that_requires_authentication) { git_lfs_url }
|
|
|
|
it_behaves_like 'rate-limited web authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { [git_lfs_url, { headers: basic_auth_headers(user, token) }] }
|
|
let(:other_user_request_args) { [git_lfs_url, { headers: basic_auth_headers(other_user, other_user_token) }] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'precedence over authenticated web throttle' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_git_lfs_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_git_lfs_period_in_seconds] = period_in_seconds
|
|
end
|
|
|
|
def do_request
|
|
get git_lfs_url, headers: basic_auth_headers(user, token)
|
|
end
|
|
|
|
context 'when authenticated git lfs throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_git_lfs_enabled] = true
|
|
end
|
|
|
|
context 'when authenticated web throttle is lower' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_web_requests_per_period] = 0
|
|
settings_to_set[:throttle_authenticated_web_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_web_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores authenticated web throttle' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when authenticated git lfs throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_git_lfs_enabled] = false
|
|
end
|
|
|
|
context 'when authenticated web throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_web_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_web_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_web_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the authenticated web rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Files API' do
|
|
let(:request_method) { 'GET' }
|
|
|
|
context 'unauthenticated' do
|
|
let_it_be(:project) { create(:project, :public, :custom_repo, files: { 'README' => 'foo' }) }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_unauthenticated_files_api' }
|
|
let(:files_path_that_does_not_require_authentication) { "/api/v4/projects/#{project.id}/repository/files/README?ref=master" }
|
|
|
|
def do_request
|
|
get files_path_that_does_not_require_authentication
|
|
end
|
|
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_files_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_files_api_period_in_seconds] = period_in_seconds
|
|
end
|
|
|
|
context 'when unauthenticated files api throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_files_api_enabled] = false
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'allows requests over the rate limit' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the unauthenticated api rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated web throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_web_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_web_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_web_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores unauthenticated web throttle' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated files api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_files_api_requests_per_period] = requests_per_period # 1
|
|
settings_to_set[:throttle_unauthenticated_files_api_period_in_seconds] = period_in_seconds # 10_000
|
|
settings_to_set[:throttle_unauthenticated_files_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
|
|
context 'when unauthenticated api throttle is lower' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_api_requests_per_period] = 0
|
|
settings_to_set[:throttle_unauthenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores unauthenticated api throttle' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'tracking when dry-run mode is set' do
|
|
let(:throttle_name) { 'throttle_unauthenticated_files_api' }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'authenticated', :api do
|
|
let_it_be(:project) { create(:project, :internal, :custom_repo, files: { 'README' => 'foo' }) }
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:token) { create(:personal_access_token, user: user) }
|
|
let_it_be(:other_user) { create(:user) }
|
|
let_it_be(:other_user_token) { create(:personal_access_token, user: other_user) }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_files_api' }
|
|
let(:api_partial_url) { "/projects/#{project.id}/repository/files/README?ref=master" }
|
|
|
|
before do
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
context 'with the token in the query string' do
|
|
let(:request_args) { [api(api_partial_url, personal_access_token: token), {}] }
|
|
let(:other_user_request_args) { [api(api_partial_url, personal_access_token: other_user_token), {}] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(api_partial_url, personal_access_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'precedence over authenticated api throttle' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_files_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_files_api_period_in_seconds] = period_in_seconds
|
|
end
|
|
|
|
def do_request
|
|
get api(api_partial_url, personal_access_token: token)
|
|
end
|
|
|
|
context 'when authenticated files api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_files_api_enabled] = true
|
|
end
|
|
|
|
context 'when authenticated api throttle is lower' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_api_requests_per_period] = 0
|
|
settings_to_set[:throttle_authenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores authenticated api throttle' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when authenticated files api throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_files_api_enabled] = false
|
|
end
|
|
|
|
context 'when authenticated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the authenticated api rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Deprecated API', :api do
|
|
let_it_be(:group) { create(:group, :public) }
|
|
|
|
let(:request_method) { 'GET' }
|
|
let(:path) { "/groups/#{group.id}" }
|
|
let(:params) { {} }
|
|
|
|
context 'unauthenticated' do
|
|
let(:throttle_setting_prefix) { 'throttle_unauthenticated_deprecated_api' }
|
|
|
|
def do_request
|
|
get(api(path), params: params)
|
|
end
|
|
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_deprecated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_deprecated_api_period_in_seconds] = period_in_seconds
|
|
end
|
|
|
|
context 'when unauthenticated deprecated api throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_deprecated_api_enabled] = false
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'allows requests over the rate limit' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the unauthenticated api rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated web throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_web_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_web_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_web_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores unauthenticated web throttle' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated deprecated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_deprecated_api_requests_per_period] = requests_per_period # 1
|
|
settings_to_set[:throttle_unauthenticated_deprecated_api_period_in_seconds] = period_in_seconds # 10_000
|
|
settings_to_set[:throttle_unauthenticated_deprecated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
context 'when group endpoint is given with_project=false' do
|
|
let(:params) { { with_projects: false } }
|
|
|
|
it 'permits requests over the rate limit' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
|
|
it 'rejects requests over the rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
|
|
context 'when unauthenticated api throttle is lower' do
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_api_requests_per_period] = 0
|
|
settings_to_set[:throttle_unauthenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_unauthenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores unauthenticated api throttle' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'tracking when dry-run mode is set' do
|
|
let(:throttle_name) { 'throttle_unauthenticated_deprecated_api' }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'authenticated' do
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:member) { group.add_owner(user) }
|
|
let_it_be(:token) { create(:personal_access_token, user: user) }
|
|
let_it_be(:other_user) { create(:user) }
|
|
let_it_be(:other_user_token) { create(:personal_access_token, user: other_user) }
|
|
|
|
let(:throttle_setting_prefix) { 'throttle_authenticated_deprecated_api' }
|
|
|
|
before do
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
context 'with the token in the query string' do
|
|
let(:request_args) { [api(path, personal_access_token: token), {}] }
|
|
let(:other_user_request_args) { [api(path, personal_access_token: other_user_token), {}] }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'with the token in the headers' do
|
|
let(:request_args) { api_get_args_with_token_headers(path, personal_access_token_headers(token)) }
|
|
let(:other_user_request_args) { api_get_args_with_token_headers(path, personal_access_token_headers(other_user_token)) }
|
|
|
|
it_behaves_like 'rate-limited token-authenticated requests'
|
|
end
|
|
|
|
context 'precedence over authenticated api throttle' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_deprecated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_deprecated_api_period_in_seconds] = period_in_seconds
|
|
end
|
|
|
|
def do_request
|
|
get(api(path, personal_access_token: token), params: params)
|
|
end
|
|
|
|
context 'when authenticated deprecated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_deprecated_api_enabled] = true
|
|
end
|
|
|
|
context 'when authenticated api throttle is lower' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_api_requests_per_period] = 0
|
|
settings_to_set[:throttle_authenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'ignores authenticated api throttle' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when authenticated deprecated api throttle is disabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_deprecated_api_enabled] = false
|
|
end
|
|
|
|
context 'when authenticated api throttle is enabled' do
|
|
before do
|
|
settings_to_set[:throttle_authenticated_api_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_authenticated_api_period_in_seconds] = period_in_seconds
|
|
settings_to_set[:throttle_authenticated_api_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
it 'rejects requests over the authenticated api rate limit' do
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'throttle bypass header' do
|
|
let(:headers) { {} }
|
|
let(:bypass_header) { 'gitlab-bypass-rate-limiting' }
|
|
|
|
def do_request
|
|
get '/users/sign_in', headers: headers
|
|
end
|
|
|
|
before do
|
|
# Disabling protected paths throttle, otherwise requests to
|
|
# '/users/sign_in' are caught by this throttle.
|
|
settings_to_set[:throttle_protected_paths_enabled] = false
|
|
|
|
# Set low limits
|
|
settings_to_set[:throttle_unauthenticated_requests_per_period] = requests_per_period
|
|
settings_to_set[:throttle_unauthenticated_period_in_seconds] = period_in_seconds
|
|
|
|
stub_env('GITLAB_THROTTLE_BYPASS_HEADER', bypass_header)
|
|
settings_to_set[:throttle_unauthenticated_enabled] = true
|
|
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
shared_examples 'reject requests over the rate limit' do
|
|
it 'rejects requests over the rate limit' do
|
|
# At first, allow requests under the rate limit.
|
|
requests_per_period.times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
# the last straw
|
|
expect_rejection { do_request }
|
|
end
|
|
end
|
|
|
|
context 'without the bypass header set' do
|
|
it_behaves_like 'reject requests over the rate limit'
|
|
end
|
|
|
|
context 'with bypass header set to 1' do
|
|
let(:headers) { { bypass_header => '1' } }
|
|
|
|
it 'does not throttle' do
|
|
(1 + requests_per_period).times do
|
|
do_request
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with bypass header set to some other value' do
|
|
let(:headers) { { bypass_header => 'some other value' } }
|
|
|
|
it_behaves_like 'reject requests over the rate limit'
|
|
end
|
|
end
|
|
|
|
describe 'Gitlab::RackAttack::Request#unauthenticated?' do
|
|
let_it_be(:url) { "/api/v4/projects" }
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
def expect_unauthenticated_request
|
|
expect_next_instance_of(Rack::Attack::Request) do |instance|
|
|
expect(instance.unauthenticated?).to be true
|
|
end
|
|
end
|
|
|
|
def expect_authenticated_request
|
|
expect_next_instance_of(Rack::Attack::Request) do |instance|
|
|
expect(instance.unauthenticated?).to be false
|
|
end
|
|
end
|
|
|
|
before do
|
|
settings_to_set[:throttle_unauthenticated_enabled] = true
|
|
stub_application_setting(settings_to_set)
|
|
end
|
|
|
|
context 'without authentication' do
|
|
it 'request is unauthenticated' do
|
|
expect_unauthenticated_request
|
|
|
|
get url
|
|
end
|
|
end
|
|
|
|
context 'authenticated by a runner token' do
|
|
let_it_be(:runner) { create(:ci_runner) }
|
|
|
|
it 'request is authenticated' do
|
|
expect_authenticated_request
|
|
|
|
get url, params: { token: runner.token }
|
|
end
|
|
end
|
|
|
|
context 'authenticated with personal access token' do
|
|
let_it_be(:personal_access_token) { create(:personal_access_token, user: user) }
|
|
|
|
it 'request is authenticated by token in query string' do
|
|
expect_authenticated_request
|
|
|
|
get url, params: { private_token: personal_access_token.token }
|
|
end
|
|
|
|
it 'request is authenticated by token in the headers' do
|
|
expect_authenticated_request
|
|
|
|
get url, headers: personal_access_token_headers(personal_access_token)
|
|
end
|
|
|
|
it 'request is authenticated by token in the OAuth headers' do
|
|
expect_authenticated_request
|
|
|
|
get url, headers: oauth_token_headers(personal_access_token)
|
|
end
|
|
|
|
it 'request is authenticated by token in basic auth' do
|
|
expect_authenticated_request
|
|
|
|
get url, headers: basic_auth_headers(user, personal_access_token)
|
|
end
|
|
end
|
|
|
|
context 'authenticated with OAuth token' do
|
|
let(:application) { Doorkeeper::Application.create!(name: "MyApp", redirect_uri: "https://app.com", owner: user) }
|
|
let(:oauth_token) { Doorkeeper::AccessToken.create!(application_id: application.id, resource_owner_id: user.id, scopes: "api") }
|
|
|
|
it 'request is authenticated by token in query string' do
|
|
expect_authenticated_request
|
|
|
|
get url, params: { access_token: oauth_token.token }
|
|
end
|
|
|
|
it 'request is authenticated by token in the headers' do
|
|
expect_authenticated_request
|
|
|
|
get url, headers: oauth_token_headers(oauth_token)
|
|
end
|
|
end
|
|
|
|
context 'authenticated with lfs token' do
|
|
let(:lfs_url) { '/namespace/repo.git/info/lfs/objects/batch' }
|
|
let(:lfs_token) { Gitlab::LfsToken.new(user) }
|
|
let(:encoded_login) { ["#{user.username}:#{lfs_token.token}"].pack('m0') }
|
|
let(:headers) { { 'AUTHORIZATION' => "Basic #{encoded_login}" } }
|
|
|
|
it 'request is authenticated by token in basic auth' do
|
|
expect_authenticated_request
|
|
|
|
get lfs_url, headers: headers
|
|
end
|
|
|
|
it 'request is not authenticated with API URL' do
|
|
expect_unauthenticated_request
|
|
|
|
get url, headers: headers
|
|
end
|
|
end
|
|
|
|
context 'authenticated with regular login' do
|
|
let(:encoded_login) { ["#{user.username}:#{user.password}"].pack('m0') }
|
|
let(:headers) { { 'AUTHORIZATION' => "Basic #{encoded_login}" } }
|
|
|
|
it 'request is authenticated after login' do
|
|
login_as(user)
|
|
|
|
expect_authenticated_request
|
|
|
|
get url
|
|
end
|
|
|
|
it 'request is not authenticated by credentials in basic auth' do
|
|
expect_unauthenticated_request
|
|
|
|
get url, headers: headers
|
|
end
|
|
|
|
context 'with POST git-upload-pack' do
|
|
it 'request is authenticated by credentials in basic auth' do
|
|
expect(::Gitlab::Workhorse).to receive(:verify_api_request!)
|
|
|
|
expect_authenticated_request
|
|
|
|
post '/namespace/repo.git/git-upload-pack', headers: headers
|
|
end
|
|
end
|
|
|
|
context 'with GET info/refs' do
|
|
it 'request is authenticated by credentials in basic auth' do
|
|
expect(::Gitlab::Workhorse).to receive(:verify_api_request!)
|
|
|
|
expect_authenticated_request
|
|
|
|
get '/namespace/repo.git/info/refs?service=git-upload-pack', headers: headers
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|