dfe13131d7
In preparation for embedding specific metrics in issues https://gitlab.com/gitlab-org/gitlab-ce/issues/62971, this commit moves the BaseService for metrics dashboards to a new services subdirectory. This is purely for the sake of organization and maintainability.
80 lines
2.8 KiB
Ruby
80 lines
2.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Gitlab::Metrics::Dashboard::Finder, :use_clean_rails_memory_store_caching do
|
|
include MetricsDashboardHelpers
|
|
|
|
set(:project) { build(:project) }
|
|
set(:user) { create(:user) }
|
|
set(:environment) { create(:environment, project: project) }
|
|
let(:system_dashboard_path) { ::Metrics::Dashboard::SystemDashboardService::SYSTEM_DASHBOARD_PATH}
|
|
|
|
before do
|
|
project.add_maintainer(user)
|
|
end
|
|
|
|
describe '.find' do
|
|
let(:dashboard_path) { '.gitlab/dashboards/test.yml' }
|
|
let(:service_call) { described_class.find(project, user, environment, dashboard_path: dashboard_path) }
|
|
|
|
it_behaves_like 'misconfigured dashboard service response', :not_found
|
|
|
|
context 'when the dashboard exists' do
|
|
let(:project) { project_with_dashboard(dashboard_path) }
|
|
|
|
it_behaves_like 'valid dashboard service response'
|
|
end
|
|
|
|
context 'when the dashboard is configured incorrectly' do
|
|
let(:project) { project_with_dashboard(dashboard_path, {}) }
|
|
|
|
it_behaves_like 'misconfigured dashboard service response', :unprocessable_entity
|
|
end
|
|
|
|
context 'when the dashboard contains a metric without a query' do
|
|
let(:dashboard) { { 'panel_groups' => [{ 'panels' => [{ 'metrics' => [{ 'id' => 'mock' }] }] }] } }
|
|
let(:project) { project_with_dashboard(dashboard_path, dashboard.to_yaml) }
|
|
|
|
it_behaves_like 'misconfigured dashboard service response', :unprocessable_entity
|
|
end
|
|
|
|
context 'when the system dashboard is specified' do
|
|
let(:dashboard_path) { system_dashboard_path }
|
|
|
|
it_behaves_like 'valid dashboard service response'
|
|
end
|
|
|
|
context 'when no dashboard is specified' do
|
|
let(:service_call) { described_class.find(project, user, environment) }
|
|
|
|
it_behaves_like 'valid dashboard service response'
|
|
end
|
|
|
|
context 'when the dashboard is expected to be embedded' do
|
|
let(:service_call) { described_class.find(project, user, environment, dashboard_path: nil, embedded: true) }
|
|
|
|
it_behaves_like 'valid embedded dashboard service response'
|
|
end
|
|
end
|
|
|
|
describe '.find_all_paths' do
|
|
let(:all_dashboard_paths) { described_class.find_all_paths(project) }
|
|
let(:system_dashboard) { { path: system_dashboard_path, display_name: 'Default', default: true } }
|
|
|
|
it 'includes only the system dashboard by default' do
|
|
expect(all_dashboard_paths).to eq([system_dashboard])
|
|
end
|
|
|
|
context 'when the project contains dashboards' do
|
|
let(:dashboard_path) { '.gitlab/dashboards/test.yml' }
|
|
let(:project) { project_with_dashboard(dashboard_path) }
|
|
|
|
it 'includes system and project dashboards' do
|
|
project_dashboard = { path: dashboard_path, display_name: 'test.yml', default: false }
|
|
|
|
expect(all_dashboard_paths).to contain_exactly(system_dashboard, project_dashboard)
|
|
end
|
|
end
|
|
end
|
|
end
|