c11006ac6c
Resolve "Destroying a project causes post_decline_request to be executed" ## What does this MR do? Ensure we don't send "access request declined" to access requesters when a project is deleted. ## Are there points in the code the reviewer needs to double check? I've created a service to decouple the notification sending from the AR model. ## Why was this MR needed? Because there was an issue. ## What are the relevant issue numbers? Fixes #18755, #18750. ## Does this MR meet the acceptance criteria? - [x] No CHANGELOG needed. - [x] Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4744 |
||
|---|---|---|
| .. | ||
| admin | ||
| ci | ||
| groups | ||
| import | ||
| oauth | ||
| profiles | ||
| projects | ||
| abuse_reports_controller_spec.rb | ||
| application_controller_spec.rb | ||
| autocomplete_controller_spec.rb | ||
| blob_controller_spec.rb | ||
| commit_controller_spec.rb | ||
| groups_controller_spec.rb | ||
| health_check_controller_spec.rb | ||
| help_controller_spec.rb | ||
| invites_controller_spec.rb | ||
| namespaces_controller_spec.rb | ||
| notification_settings_controller_spec.rb | ||
| projects_controller_spec.rb | ||
| registrations_controller_spec.rb | ||
| root_controller_spec.rb | ||
| sent_notifications_controller_spec.rb | ||
| sessions_controller_spec.rb | ||
| snippets_controller_spec.rb | ||
| uploads_controller_spec.rb | ||
| users_controller_spec.rb | ||