gitlab-org--gitlab-foss/spec/features
Douwe Maan 4dcf107b26 Merge branch '18871-check-improve-how-we-display-access-requesters-in-admin-area' into 'master'
Display group/project access requesters separately in admin

## What does this MR do?

It displays the access requesters in a separate list in group & project members pages.

It also harmonize the members counter UI to use `%span.badge` everywhere (in the admin & non-admin members views).

## Are there points in the code the reviewer needs to double check?

No.

## Why was this MR needed?

To not confuse access requesters with actual members.

## What are the relevant issue numbers?

Closes #18871.

## Screenshots

### Group members

| Before | After |
| --------- | ---- |
| ![group-members-before](/uploads/2f15137e073fd3a63bc2cb7b2217cb6c/group-members-before.png) | ![group-members-after](/uploads/5b643974505cfa57783fa0320d3bf8b2/group-members-after.png) |

### Project members

| Before | After |
| --------- | ---- |
| ![project-members-before](/uploads/9c48dcd3736e42de84061b1201ee0b06/project-members-before.png) | ![project-members-after](/uploads/8e04c92ef0bba3de7e2405618632b27d/project-members-after.png) |

### Admin group members

| Before | After |
| --------- | ---- |
| ![admin-group-members-before](/uploads/7fda8c2c94b697bea6655ba892ba45e7/admin-group-members-before.png) | ![admin-group-members-after](/uploads/ea25717001794f75939c679b80308c3a/admin-group-members-after.png) |

### Admin project members

| Before | After |
| --------- | ---- |
| ![admin-project-members-before](/uploads/ba9d3ec52adbda6bb3d45ad9ac5243d3/admin-project-members-before.png) | ![admin-project-members-after](/uploads/3b889a029a9756e9ed2781b45c4dd9cb/admin-project-members-after.png) |

## Does this MR meet the acceptance criteria?

- [x] No CHANGELOG since this is related to the original "request access" MR.
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4798
2016-06-22 01:17:08 +00:00
..
admin Test for enabling/disabling runners from admin runner page 2016-06-17 22:17:20 +08:00
atom Apply reviewer notes: update CHANGELOG, adjust code formatting 2016-06-13 09:51:55 -07:00
dashboard Change date format to be non zero padded in order to fix failing test 2016-06-09 14:38:24 -05:00
groups/members Merge branch '18871-check-improve-how-we-display-access-requesters-in-admin-area' into 'master' 2016-06-22 01:17:08 +00:00
issues Merge branch '18714_bulk_assign_labels_icon' into 'master' 2016-06-18 16:29:43 +00:00
merge_requests Rename ci_commit -> pipeline 2016-06-10 14:41:38 +02:00
profiles Implement @DouweM's feedback. 2016-06-16 08:24:13 +05:30
projects Merge branch '18871-check-improve-how-we-display-access-requesters-in-admin-area' into 'master' 2016-06-22 01:17:08 +00:00
security Authorize environments controller actions 2016-06-14 14:43:45 +02:00
tags
todos Ensure Todos counters doesn't count Todos for projects pending delete 2016-06-17 16:17:43 -03:00
builds_spec.rb Fix specs 2016-06-14 11:38:34 +02:00
ci_lint_spec.rb
commits_spec.rb Rename all [ci_]commit to [ci_]pipeline in specs and features 2016-06-03 16:22:26 +02:00
container_registry_spec.rb Show proper image ID on registry page 2016-06-21 13:08:10 +02:00
dashboard_issues_spec.rb
dashboard_milestones_spec.rb
environments_spec.rb Tests update 2016-06-21 11:52:51 +01:00
gitlab_flavored_markdown_spec.rb
groups_spec.rb
help_pages_spec.rb
issues_spec.rb Make tests pass. 2016-06-17 11:52:22 +01:00
login_spec.rb Implement authentication (login) using a U2F device. 2016-06-06 12:50:31 +05:30
markdown_spec.rb Merge branch '18019-fix-wiki-linking' into 'master' 2016-06-09 08:37:27 +00:00
milestone_spec.rb
notes_on_merge_requests_spec.rb
participants_autocomplete_spec.rb
password_reset_spec.rb
pipelines_spec.rb Rename all [ci_]commit to [ci_]pipeline in specs and features 2016-06-03 16:22:26 +02:00
profile_spec.rb
projects_spec.rb Fix and remove duplicate specs 2016-06-20 12:36:59 +02:00
runners_spec.rb
search_spec.rb Fix specs and add new tests. 2016-06-10 01:05:09 +03:00
signup_spec.rb
task_lists_spec.rb
triggers_spec.rb
u2f_spec.rb Update u2f_spec to cover U2F being disabled until authenticator is set up. 2016-06-15 08:16:54 +05:30
users_spec.rb
variables_spec.rb