Douwe Maan c11006ac6c Merge branch '18755-fix-destroy-project-causes-post_decline_request-to-be-executed' into 'master' ... Resolve "Destroying a project causes post_decline_request to be executed" ## What does this MR do? Ensure we don't send "access request declined" to access requesters when a project is deleted. ## Are there points in the code the reviewer needs to double check? I've created a service to decouple the notification sending from the AR model. ## Why was this MR needed? Because there was an issue. ## What are the relevant issue numbers? Fixes #18755, #18750. ## Does this MR meet the acceptance criteria? - [x] No CHANGELOG needed. - [x] Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4744		2016-06-22 01:15:29 +00:00
..
ci	Rename according to:	2016-06-20 16:52:05 +08:00
concerns	Cache Participable#participants in instance variable	2016-06-21 12:54:12 +02:00
hooks
members	New Members::DestroyService	2016-06-18 05:46:45 +02:00
project_services	Remove JiraIssue model and replace references with ExternalIssue	2016-06-16 01:25:18 +03:00
ability_spec.rb	Refactor Participable	2016-06-01 16:22:35 +02:00
abuse_report_spec.rb
appearance_spec.rb
application_setting_spec.rb
award_emoji_spec.rb	Incorportate feedback	2016-06-01 12:10:08 +02:00
blob_spec.rb
broadcast_message_spec.rb
build_spec.rb	Fix builds API response not including commit data	2016-06-21 14:26:57 +02:00
commit_range_spec.rb	Fix note validation spec failures	2016-06-01 10:31:46 -07:00
commit_spec.rb	Optimize Banzai::Filter::RelativeLinkFilter	2016-06-21 10:53:16 -04:00
commit_status_spec.rb	Fix builds API response not including commit data	2016-06-21 14:26:57 +02:00
deploy_key_spec.rb
deploy_keys_project_spec.rb
deployment_spec.rb	Add specs for models and services	2016-06-14 13:51:12 +02:00
email_spec.rb
environment_spec.rb	Add specs for models and services	2016-06-14 13:51:12 +02:00
event_spec.rb	Project members with guest role can't access confidential issues	2016-06-13 19:32:00 -03:00
external_issue_spec.rb
forked_project_link_spec.rb
generic_commit_status_spec.rb	Rename all [ci_]commit to [ci_]pipeline in specs and features	2016-06-03 16:22:26 +02:00
global_milestone_spec.rb
group_spec.rb	Turn Group#owners into a has_many association	2016-06-16 11:10:41 +02:00
identity_spec.rb
issue_spec.rb	Update specs. Add CHANGELOG entry	2016-06-02 09:25:40 -04:00
key_spec.rb	Remove Duplicated keys add UNIQUE index to fingerprint	2016-06-20 13:29:04 +02:00
label_link_spec.rb
label_spec.rb
legacy_diff_note_spec.rb	Improve note factory	2016-05-29 15:03:00 -04:00
member_spec.rb	New Members::DestroyService	2016-06-18 05:46:45 +02:00
merge_request_spec.rb	Rename ci_commit -> pipeline	2016-06-10 14:41:38 +02:00
milestone_spec.rb
namespace_spec.rb
note_spec.rb	Project members with guest role can't access confidential issues	2016-06-13 19:32:00 -03:00
notification_setting_spec.rb	Implement custom notification level options	2016-06-15 11:47:50 -03:00
personal_access_token_spec.rb	Fix rubocop spec.	2016-06-03 10:11:36 +05:30
project_group_link_spec.rb
project_security_spec.rb
project_snippet_spec.rb
project_spec.rb	Fixed ordering in Project.find_with_namespace	2016-06-16 13:04:59 +02:00
project_team_spec.rb	UI and copywriting improvements	2016-06-14 13:18:14 +02:00
project_wiki_spec.rb	Fix hook data for Wiki Page event	2016-05-31 11:24:58 -03:00
protected_branch_spec.rb
release_spec.rb
repository_spec.rb	Add sorting dropdown to tag page	2016-06-16 13:33:29 -04:00
service_spec.rb	Cache the presence of an issue_tracker at project level	2016-06-10 15:41:56 +02:00
snippet_spec.rb	Refactor Participable	2016-06-01 16:22:35 +02:00
spam_log_spec.rb
todo_spec.rb
tree_spec.rb
user_spec.rb	Add a blank line between before and it:	2016-06-07 22:34:09 +08:00
wiki_page_spec.rb