4fd848fc7a
1. When removing projects, we can end-up leaving the +deleted repo path dirty and not successfully removing the non-deleted namespace (mv process is not atomic and can be killed without fully moving the path). 2. In order to solve that, we're adding a clean-up phase on ensure which will schedule possible staled +deleted path deletion. Note that we don't check the current state (if there is or not a repo) in order to schedule the deletion. That's intentional in order to leverage Gitlab::GitalyClient::NamespaceService#remove idempotency and ensure consistency.
347 lines
11 KiB
Ruby
347 lines
11 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Projects::DestroyService do
|
|
include ProjectForksHelper
|
|
|
|
let!(:user) { create(:user) }
|
|
let!(:project) { create(:project, :repository, namespace: user.namespace) }
|
|
let!(:path) do
|
|
Gitlab::GitalyClient::StorageSettings.allow_disk_access do
|
|
project.repository.path_to_repo
|
|
end
|
|
end
|
|
let!(:remove_path) { path.sub(/\.git\Z/, "+#{project.id}+deleted.git") }
|
|
let!(:async) { false } # execute or async_execute
|
|
|
|
before do
|
|
stub_container_registry_config(enabled: true)
|
|
stub_container_registry_tags(repository: :any, tags: [])
|
|
end
|
|
|
|
shared_examples 'deleting the project' do
|
|
it 'deletes the project' do
|
|
expect(Project.unscoped.all).not_to include(project)
|
|
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, path + '.git')).to be_falsey
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, remove_path + '.git')).to be_falsey
|
|
end
|
|
end
|
|
|
|
shared_examples 'deleting the project with pipeline and build' do
|
|
context 'with pipeline and build' do # which has optimistic locking
|
|
let!(:pipeline) { create(:ci_pipeline, project: project) }
|
|
let!(:build) { create(:ci_build, :artifacts, pipeline: pipeline) }
|
|
|
|
before do
|
|
perform_enqueued_jobs do
|
|
destroy_project(project, user, {})
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
end
|
|
end
|
|
|
|
shared_examples 'handles errors thrown during async destroy' do |error_message|
|
|
it 'does not allow the error to bubble up' do
|
|
expect do
|
|
perform_enqueued_jobs { destroy_project(project, user, {}) }
|
|
end.not_to raise_error
|
|
end
|
|
|
|
it 'unmarks the project as "pending deletion"' do
|
|
perform_enqueued_jobs { destroy_project(project, user, {}) }
|
|
|
|
expect(project.reload.pending_delete).to be(false)
|
|
end
|
|
|
|
it 'stores an error message in `projects.delete_error`' do
|
|
perform_enqueued_jobs { destroy_project(project, user, {}) }
|
|
|
|
expect(project.reload.delete_error).to be_present
|
|
expect(project.delete_error).to include(error_message)
|
|
end
|
|
end
|
|
|
|
context 'Sidekiq inline' do
|
|
before do
|
|
# Run sidekiq immediately to check that renamed repository will be removed
|
|
perform_enqueued_jobs { destroy_project(project, user, {}) }
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
|
|
context 'when has remote mirrors' do
|
|
let!(:project) do
|
|
create(:project, :repository, namespace: user.namespace).tap do |project|
|
|
project.remote_mirrors.create(url: 'http://test.com')
|
|
end
|
|
end
|
|
let!(:async) { true }
|
|
|
|
it 'destroys them' do
|
|
expect(RemoteMirror.count).to eq(0)
|
|
end
|
|
end
|
|
|
|
it 'invalidates personal_project_count cache' do
|
|
expect(user).to receive(:invalidate_personal_projects_count)
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
|
|
context 'when project has exports' do
|
|
let!(:project_with_export) do
|
|
create(:project, :repository, namespace: user.namespace).tap do |project|
|
|
create(:import_export_upload,
|
|
project: project,
|
|
export_file: fixture_file_upload('spec/fixtures/project_export.tar.gz'))
|
|
end
|
|
end
|
|
let!(:async) { true }
|
|
|
|
it 'destroys project and export' do
|
|
expect { destroy_project(project_with_export, user) }.to change(ImportExportUpload, :count).by(-1)
|
|
|
|
expect(Project.all).not_to include(project_with_export)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'Sidekiq fake' do
|
|
before do
|
|
# Dont run sidekiq to check if renamed repository exists
|
|
Sidekiq::Testing.fake! { destroy_project(project, user, {}) }
|
|
end
|
|
|
|
it { expect(Project.all).not_to include(project) }
|
|
it { expect(Dir.exist?(path)).to be_falsey }
|
|
it { expect(Dir.exist?(remove_path)).to be_truthy }
|
|
end
|
|
|
|
context 'when flushing caches fail' do
|
|
before do
|
|
new_user = create(:user)
|
|
project.team.add_user(new_user, Gitlab::Access::DEVELOPER)
|
|
allow_any_instance_of(described_class).to receive(:flush_caches).and_raise(::Redis::CannotConnectError)
|
|
end
|
|
|
|
it 'keeps project team intact upon an error' do
|
|
perform_enqueued_jobs do
|
|
begin
|
|
destroy_project(project, user, {})
|
|
rescue ::Redis::CannotConnectError
|
|
end
|
|
end
|
|
|
|
expect(project.team.members.count).to eq 2
|
|
end
|
|
end
|
|
|
|
context 'with async_execute' do
|
|
let(:async) { true }
|
|
|
|
context 'async delete of project with private issue visibility' do
|
|
before do
|
|
project.project_feature.update_attribute("issues_access_level", ProjectFeature::PRIVATE)
|
|
# Run sidekiq immediately to check that renamed repository will be removed
|
|
perform_enqueued_jobs { destroy_project(project, user, {}) }
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
end
|
|
|
|
it_behaves_like 'deleting the project with pipeline and build'
|
|
|
|
context 'errors' do
|
|
context 'when `remove_legacy_registry_tags` fails' do
|
|
before do
|
|
expect_any_instance_of(described_class)
|
|
.to receive(:remove_legacy_registry_tags).and_return(false)
|
|
end
|
|
|
|
it_behaves_like 'handles errors thrown during async destroy', "Failed to remove some tags"
|
|
end
|
|
|
|
context 'when `remove_repository` fails' do
|
|
before do
|
|
expect_any_instance_of(described_class)
|
|
.to receive(:remove_repository).and_return(false)
|
|
end
|
|
|
|
it_behaves_like 'handles errors thrown during async destroy', "Failed to remove project repository"
|
|
end
|
|
|
|
context 'when `execute` raises expected error' do
|
|
before do
|
|
expect_any_instance_of(Project)
|
|
.to receive(:destroy!).and_raise(StandardError.new("Other error message"))
|
|
end
|
|
|
|
it_behaves_like 'handles errors thrown during async destroy', "Other error message"
|
|
end
|
|
|
|
context 'when `execute` raises unexpected error' do
|
|
before do
|
|
expect_any_instance_of(Project)
|
|
.to receive(:destroy!).and_raise(Exception.new('Other error message'))
|
|
end
|
|
|
|
it 'allows error to bubble up and rolls back project deletion' do
|
|
expect do
|
|
perform_enqueued_jobs { destroy_project(project, user, {}) }
|
|
end.to raise_error(Exception, 'Other error message')
|
|
|
|
expect(project.reload.pending_delete).to be(false)
|
|
expect(project.delete_error).to include("Other error message")
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'container registry' do
|
|
context 'when there are regular container repositories' do
|
|
let(:container_repository) { create(:container_repository) }
|
|
|
|
before do
|
|
stub_container_registry_tags(repository: project.full_path + '/image',
|
|
tags: ['tag'])
|
|
project.container_repositories << container_repository
|
|
end
|
|
|
|
context 'when image repository deletion succeeds' do
|
|
it 'removes tags' do
|
|
expect_any_instance_of(ContainerRepository)
|
|
.to receive(:delete_tags!).and_return(true)
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
end
|
|
|
|
context 'when image repository deletion fails' do
|
|
it 'raises an exception' do
|
|
expect_any_instance_of(ContainerRepository)
|
|
.to receive(:delete_tags!).and_raise(RuntimeError)
|
|
|
|
expect(destroy_project(project, user)).to be false
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when there are tags for legacy root repository' do
|
|
before do
|
|
stub_container_registry_tags(repository: project.full_path,
|
|
tags: ['tag'])
|
|
end
|
|
|
|
context 'when image repository tags deletion succeeds' do
|
|
it 'removes tags' do
|
|
expect_any_instance_of(ContainerRepository)
|
|
.to receive(:delete_tags!).and_return(true)
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
end
|
|
|
|
context 'when image repository tags deletion fails' do
|
|
it 'raises an exception' do
|
|
expect_any_instance_of(ContainerRepository)
|
|
.to receive(:delete_tags!).and_return(false)
|
|
|
|
expect(destroy_project(project, user)).to be false
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'for a forked project with LFS objects' do
|
|
let(:forked_project) { fork_project(project, user) }
|
|
|
|
before do
|
|
project.lfs_objects << create(:lfs_object)
|
|
forked_project.reload
|
|
end
|
|
|
|
it 'destroys the fork' do
|
|
expect { destroy_project(forked_project, user) }
|
|
.not_to raise_error
|
|
end
|
|
end
|
|
|
|
context 'as the root of a fork network' do
|
|
let!(:fork_network) { create(:fork_network, root_project: project) }
|
|
|
|
it 'updates the fork network with the project name' do
|
|
destroy_project(project, user)
|
|
|
|
fork_network.reload
|
|
|
|
expect(fork_network.deleted_root_project_name).to eq(project.full_name)
|
|
expect(fork_network.root_project).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'repository +deleted path removal' do
|
|
def removal_path(path)
|
|
"#{path}+#{project.id}#{described_class::DELETED_FLAG}"
|
|
end
|
|
|
|
context 'regular phase' do
|
|
it 'schedules +deleted removal of existing repos' do
|
|
service = described_class.new(project, user, {})
|
|
allow(service).to receive(:schedule_stale_repos_removal)
|
|
|
|
expect(GitlabShellWorker).to receive(:perform_in)
|
|
.with(5.minutes, :remove_repository, project.repository_storage, removal_path(project.disk_path))
|
|
|
|
service.execute
|
|
end
|
|
end
|
|
|
|
context 'stale cleanup' do
|
|
let!(:async) { true }
|
|
|
|
it 'schedules +deleted wiki and repo removal' do
|
|
allow(ProjectDestroyWorker).to receive(:perform_async)
|
|
|
|
expect(GitlabShellWorker).to receive(:perform_in)
|
|
.with(10.minutes, :remove_repository, project.repository_storage, removal_path(project.disk_path))
|
|
|
|
expect(GitlabShellWorker).to receive(:perform_in)
|
|
.with(10.minutes, :remove_repository, project.repository_storage, removal_path(project.wiki.disk_path))
|
|
|
|
destroy_project(project, user, {})
|
|
end
|
|
end
|
|
end
|
|
|
|
context '#attempt_restore_repositories' do
|
|
let(:path) { project.disk_path + '.git' }
|
|
|
|
before do
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, path)).to be_truthy
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, remove_path)).to be_falsey
|
|
|
|
# Dont run sidekiq to check if renamed repository exists
|
|
Sidekiq::Testing.fake! { destroy_project(project, user, {}) }
|
|
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, path)).to be_falsey
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, remove_path)).to be_truthy
|
|
end
|
|
|
|
it 'restores the repositories' do
|
|
Sidekiq::Testing.fake! { described_class.new(project, user).attempt_repositories_rollback }
|
|
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, path)).to be_truthy
|
|
expect(project.gitlab_shell.exists?(project.repository_storage, remove_path)).to be_falsey
|
|
end
|
|
end
|
|
|
|
def destroy_project(project, user, params = {})
|
|
if async
|
|
Projects::DestroyService.new(project, user, params).async_execute
|
|
else
|
|
Projects::DestroyService.new(project, user, params).execute
|
|
end
|
|
end
|
|
end
|