ec0061a95c
Changes include: - Ensure Member.add_user is not called directly when not necessary - New GroupMember.add_users_to_group to have the same abstraction level as for Project - Refactor Member.add_user to take a source instead of an array of members - Fix Rubocop offenses - Always use Project#add_user instead of project.team.add_user - Factorize users addition as members in Member.add_users_to_source - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects - Destroy any requester before adding them as a member - Improve the way we handle access requesters in Member.add_user Instead of removing the requester and creating a new member, we now simply accepts their access request. This way, they will receive a "access request granted" email. - Fix error that was previously silently ignored - Stop raising when access level is invalid in Member, let Rails validation do their work Signed-off-by: Rémy Coutable <remy@rymai.me> |
||
|---|---|---|
| .. | ||
| anonymous_user_sees_members_spec.rb | ||
| group_member_cannot_leave_group_project_spec.rb | ||
| group_member_cannot_request_access_to_his_group_project_spec.rb | ||
| group_requester_cannot_request_access_to_project_spec.rb | ||
| master_adds_member_with_expiration_date_spec.rb | ||
| master_manages_access_requests_spec.rb | ||
| member_cannot_request_access_to_his_project_spec.rb | ||
| member_leaves_project_spec.rb | ||
| owner_cannot_leave_project_spec.rb | ||
| owner_cannot_request_access_to_his_project_spec.rb | ||
| user_requests_access_spec.rb | ||