Robert Speicher e64594ac44 Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master' ... Resolve "`Member.add_user`doesn't detect existing members that have requested access" ## What does this MR do? This merge request handle the case when an access requester is added to a group or project (via the members page or the API). In `Member.add_user`, if an access requester already exists, we simply accept their request (and set the `created_by`, `access_level` and `expires_at` attributes if given). ## Are there points in the code the reviewer needs to double check? I've taken the opportunity to cleanup the whole `{Group,Project}Member.add_user*` methods since it was quite a mess. ## What are the relevant issue numbers? Closes #21983 See merge request !6393		2016-10-02 11:42:57 +00:00
..
admin	Fix incorrect "stopped impersonation" log message	2016-08-23 01:09:16 -07:00
ci	Redirect to root path when visiting /ci	2016-03-29 08:04:17 +02:00
groups	Ensure Members::ApproveAccessRequestService can fin a requester by ID	2016-09-22 15:50:48 +02:00
import	modify github import JS and controller so we can now specify a namespace and/or name for a project.	2016-09-20 10:14:39 +02:00
oauth	Use HTTP matchers if possible	2016-06-27 20:10:42 +02:00
profiles	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
projects	Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master'	2016-10-02 11:42:57 +00:00
abuse_reports_controller_spec.rb	Add AbuseReport#notify	2016-01-04 18:59:42 -05:00
application_controller_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
autocomplete_controller_spec.rb	Move to project dropdown with infinite scroll for better performance	2016-08-18 15:31:51 +02:00
blob_controller_spec.rb	Fix Error 500 when viewing a blob with binary characters after the 1024-byte mark	2016-06-12 07:36:25 -07:00
groups_controller_spec.rb	This fixes a long running tests due to changed Sidekiq state	2016-08-15 23:26:40 +02:00
health_check_controller_spec.rb	Use HTTP matchers if possible	2016-06-27 20:10:42 +02:00
help_controller_spec.rb	Fix failing spec on help controller	2016-07-22 11:49:09 +03:00
invites_controller_spec.rb	Use HTTP matchers if possible	2016-06-27 20:10:42 +02:00
namespaces_controller_spec.rb	Use HTTP matchers if possible	2016-06-27 20:10:42 +02:00
notification_settings_controller_spec.rb	Merge branch 'master' into issue_3359_3	2016-06-29 11:32:38 -03:00
projects_controller_spec.rb	fix broken repo 500 errors in UI and added relevant specs	2016-09-29 16:58:14 +02:00
registrations_controller_spec.rb	Assert against ActionMailer::Base.deliveries relatively.	2016-07-05 10:20:32 +05:30
root_controller_spec.rb	Implementing 'Groups View' and 'TODOs View' as options for dashboard preferences.	2016-03-24 19:59:54 +01:00
sent_notifications_controller_spec.rb	Fix initial implementation to actually render the unsubscribe page	2016-09-20 09:52:57 +02:00
sessions_controller_spec.rb	Pass the remember_me option into the u2f form and support it while authenticating	2016-09-01 17:11:42 -07:00
snippets_controller_spec.rb	Fix tests for Snippets toggling awards	2016-09-19 19:53:09 +03:00
uploads_controller_spec.rb	Use HTTP matchers if possible	2016-06-27 20:10:42 +02:00
users_controller_spec.rb	Enable Style/EmptyLines cop, remove redundant ones	2016-07-01 21:56:17 +02:00