kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/services
History
Douwe Maan 51087cfa1a Merge branch 'artifacts-from-ref-and-build-name' into 'master' 
Add a download buttons for Build Artifacts

## What does this MR do?
This MR adds a download buttons for build artifacts of latest succesful pipeline in:
- dashboard of project,
- branches and tags views,
- and tree viewer

Implement #4255

## What are the relevant issue numbers?

Closes #4255, Closes #14419

## Screenshots

### Project main

![](/uploads/29ee2154a214416059a875f2715d4fa3/Screen_Shot_2016-08-24_at_8.00.31_PM.png)

### Branches

![](/uploads/9220c593288370986fbc1d42a1425ef7/Screen_Shot_2016-08-24_at_8.02.01_PM.png)

### Tags

![](/uploads/a843e8103221fea475a0cf9d62a1999d/Screen_Shot_2016-08-24_at_8.03.32_PM.png)

### Source Tree

![](/uploads/63cd3c8c91b6f427c166dc90d8e3c059/Screen_Shot_2016-08-24_at_8.04.56_PM.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] Download buttons
- [x] Models
- [x] Routes
- [x] Projects::ArtifactsController
- [x] API
- Tests
  - Rails
      - [x] Project#builds_for
      - [x] branch name with slashes
      - [x] only success builds
      - [x] only latest builds
      - [x] feature tests for download buttons
  - API
      - [x] branch name with slashes
      - [x] only success builds
      - [x] only latest builds
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5142
2016-08-30 18:03:16 +00:00
..
auth Allow to access Container Registry for Public and Internal projects 2016-07-15 17:05:41 +02:00
boards Label list shows all issues (opened or closed) with that label 2016-08-25 09:39:23 -03:00
ci Merge remote-tracking branch 'upstream/master' into artifacts-from-ref-and-build-name 2016-08-24 20:56:30 +08:00
files Prevents accidental overwrites of commits from UI 2016-08-15 02:34:55 +00:00
groups Update tests for the current_application_settings request store changes 2016-05-27 19:05:52 -07:00
issues Merge branch '4273-slash-commands' into 'master' 2016-08-18 16:41:16 -05:00
members Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member 2016-06-18 06:06:34 +02:00
merge_requests Fix resolving conflicts on forks 2016-08-30 11:56:11 +01:00
milestones Avoid describe-ing symbols in specs 2016-07-12 10:27:58 -05:00
notes Remove unneeded aliases 2016-08-18 14:29:48 -05:00
projects adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
search Fix visibility of private project snippets for members when searching 2016-06-22 20:09:19 -03:00
slash_commands Remove unneeded aliases 2016-08-18 14:29:48 -05:00
create_deployment_service_spec.rb Fix creation of deployment on build that is retried, redeployed or rollback 2016-07-16 11:50:59 +02:00
create_release_service_spec.rb Tag service specs 2015-12-09 11:55:49 +01:00
create_snippet_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
create_tag_service_spec.rb Better message for git hooks and file locks 2016-07-04 15:31:49 +03:00
delete_tag_service_spec.rb Delete tags via rugged 2016-04-15 16:05:04 +02:00
delete_user_service_spec.rb Fix bug where destroying a namespace would not always destroy projects 2016-08-11 15:36:35 -07:00
destroy_group_service_spec.rb Fix bug where destroying a namespace would not always destroy projects 2016-08-11 15:36:35 -07:00
event_create_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
git_hooks_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
git_push_service_spec.rb Backport EE assertions in protected branch related specs. 2016-08-16 22:19:49 +05:30
git_tag_push_service_spec.rb Expire branch/tag git data when needed. 2016-06-30 16:17:38 +02:00
import_export_clean_up_service_spec.rb fix spec 2016-08-04 13:39:38 +02:00
notification_service_spec.rb Fix notification_service argument error of declined invitation emails 2016-08-19 13:18:13 +02:00
repair_ldap_blocked_user_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
repository_archive_clean_up_service_spec.rb Extract helper methods to clean up RepositoryArchiveCleanUpService spec 2016-07-21 11:47:28 -03:00
search_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
system_hooks_service_spec.rb Merge branch 'add_username_to_user_system_hooks' of https://github.com/tbeadle/gitlabhq 2016-01-13 10:12:30 +01:00
system_note_service_spec.rb Capitalize mentioned issue timeline notes 2016-08-25 10:47:40 -05:00
test_hook_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
todo_service_spec.rb Add specs to ensure a successful return 2016-08-25 06:46:11 +02:00
update_release_service_spec.rb Tag service specs 2015-12-09 11:55:49 +01:00
update_snippet_service_spec.rb Fix more specs 2016-03-20 23:09:33 +01:00