gitlab-org--gitlab-foss/spec/features/projects
Robert Speicher e64594ac44 Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master'
Resolve "`Member.add_user`doesn't detect existing members that have requested access"

## What does this MR do?

This merge request handle the case when an access requester is added to a group or project (via the members page or the API).

In `Member.add_user`, if an access requester already exists, we simply accept their request (and set the `created_by`, `access_level` and `expires_at` attributes if given).

## Are there points in the code the reviewer needs to double check?

I've taken the opportunity to cleanup the whole `{Group,Project}Member.add_user*` methods since it was quite a mess.

## What are the relevant issue numbers?

Closes #21983

See merge request !6393
2016-10-02 11:42:57 +00:00
..
badges Update coverage report badge feature tests 2016-08-18 16:30:43 +02:00
branches Fix download artifacts button link: 2016-09-19 13:12:45 +08:00
commit Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
commits Add a test for the cherry pick dropdown. 2016-08-17 09:23:43 -06:00
files Review changes 2016-10-01 00:01:47 +03:00
import_export fixing security specs after merge 2016-09-21 14:36:28 +02:00
issues Hide Create new list button on Issues and MRs pages 2016-08-17 16:39:33 -03:00
labels fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
main Fix download artifacts button link: 2016-09-19 13:12:45 +08:00
members Allow Member.add_user to handle access requesters 2016-09-28 09:43:00 +02:00
merge_requests Hide Create new list button on Issues and MRs pages 2016-08-17 16:39:33 -03:00
slack_service Refactor service settings view 2016-07-20 12:11:37 -03:00
tags Fix download artifacts button link: 2016-09-19 13:12:45 +08:00
wiki WikiPage should have a slug even when not persisted. 2016-07-25 09:22:47 +05:30
branches_spec.rb Hides merge request button on branches page 2016-09-02 14:33:24 +01:00
builds_spec.rb improve code after review 2016-09-06 14:42:43 +02:00
developer_views_empty_project_instructions_spec.rb
edit_spec.rb Hides merge request section in edit project when disabled 2016-09-02 12:03:49 +01:00
features_visibility_spec.rb Project tools visibility level 2016-09-01 11:47:59 -03:00
gfm_autocomplete_load_spec.rb Use admin user in tests 2016-09-16 10:49:55 +01:00
group_links_spec.rb Allow project group links to be expired 2016-08-18 22:45:41 +01:00
issuable_templates_spec.rb Fix issuable templates dropdown for forked projects 2016-09-15 15:51:09 -03:00
pipelines_spec.rb Move deployable conditional to variable; fix pipelines_spec 2016-08-17 11:10:11 -05:00
project_settings_spec.rb Fix Project#to_param to keep invalid project suitable for use in URLs 2016-07-27 13:52:45 -03:00
ref_switcher_spec.rb Added ref switcher enter key tests 2016-07-19 20:26:41 +01:00
shortcuts_spec.rb
snippets_spec.rb Fix snippets pagination 2016-09-26 12:42:12 +02:00