e64594ac44
Resolve "`Member.add_user`doesn't detect existing members that have requested access" ## What does this MR do? This merge request handle the case when an access requester is added to a group or project (via the members page or the API). In `Member.add_user`, if an access requester already exists, we simply accept their request (and set the `created_by`, `access_level` and `expires_at` attributes if given). ## Are there points in the code the reviewer needs to double check? I've taken the opportunity to cleanup the whole `{Group,Project}Member.add_user*` methods since it was quite a mess. ## What are the relevant issue numbers? Closes #21983 See merge request !6393 |
||
---|---|---|
.. | ||
badges | ||
branches | ||
commit | ||
commits | ||
files | ||
import_export | ||
issues | ||
labels | ||
main | ||
members | ||
merge_requests | ||
slack_service | ||
tags | ||
wiki | ||
branches_spec.rb | ||
builds_spec.rb | ||
developer_views_empty_project_instructions_spec.rb | ||
edit_spec.rb | ||
features_visibility_spec.rb | ||
gfm_autocomplete_load_spec.rb | ||
group_links_spec.rb | ||
issuable_templates_spec.rb | ||
pipelines_spec.rb | ||
project_settings_spec.rb | ||
ref_switcher_spec.rb | ||
shortcuts_spec.rb | ||
snippets_spec.rb |