kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/models
History
Robert Speicher e64594ac44 Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master' 
Resolve "`Member.add_user`doesn't detect existing members that have requested access"

## What does this MR do?

This merge request handle the case when an access requester is added to a group or project (via the members page or the API).

In `Member.add_user`, if an access requester already exists, we simply accept their request (and set the `created_by`, `access_level` and `expires_at` attributes if given).

## Are there points in the code the reviewer needs to double check?

I've taken the opportunity to cleanup the whole `{Group,Project}Member.add_user*` methods since it was quite a mess.

## What are the relevant issue numbers?

Closes #21983

See merge request !6393
2016-10-02 11:42:57 +00:00
..
ci Fix build. 2016-09-21 02:59:17 +05:30
concerns Re-add the AccessRequestable concern 2016-09-22 11:12:17 +02:00
cycle_analytics Fix the "Commits" section of the cycle analytics summary. 2016-09-26 18:38:40 +05:30
hooks Remove schema annotations completely 2016-09-16 14:37:48 +03:00
issue Fix spec failures. 2016-09-20 16:53:12 +05:30
members Allow Member.add_user to handle access requesters 2016-09-28 09:43:00 +02:00
merge_request Fix spec failures. 2016-09-20 16:53:12 +05:30
network Fix Error 500 resulting when loading network graph 2016-08-20 09:57:20 -07:00
project_services added more specs 2016-09-26 09:49:05 +02:00
ability_spec.rb Project tools visibility level 2016-09-01 11:47:59 -03:00
abuse_report_spec.rb
appearance_spec.rb
application_setting_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
award_emoji_spec.rb
blob_spec.rb Handle encoding in non-binary Blob instances 2016-09-14 14:15:31 +02:00
board_spec.rb The lists: Backlog, and Done cannot be destroyed 2016-08-17 12:58:57 -03:00
broadcast_message_spec.rb Now we already included it in spec_helper.rb 2016-08-20 00:11:03 +08:00
build_spec.rb Don't leak build tokens in build logs 2016-09-19 12:38:10 +02:00
commit_range_spec.rb Use JavaScript tooltips for mentions (!5301) 2016-09-01 01:21:34 +02:00
commit_spec.rb Expand commit message width in repo view 2016-08-02 11:40:44 -05:00
commit_status_spec.rb Merge branch 'group-similar' into 'master' 2016-09-15 15:41:15 +00:00
compare_spec.rb switch from diff_file_collection to diffs 2016-08-03 07:00:20 +02:00
deploy_key_spec.rb
deploy_keys_project_spec.rb
deployment_spec.rb Method names changed to #includes_commit? 2016-08-12 10:43:04 +02:00
diff_note_spec.rb Optimize discussion notes resolving and unresolving 2016-09-06 12:14:09 -03:00
discussion_spec.rb Optimize discussion notes resolving and unresolving 2016-09-06 12:14:09 -03:00
email_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
environment_spec.rb Fix validation regexs (+1 squashed commit) 2016-09-19 10:07:15 +02:00
event_spec.rb Restrict last_activity_at updates to one per hour 2016-09-19 16:48:58 +02:00
external_issue_spec.rb
forked_project_link_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
generic_commit_status_spec.rb Avoid describe-ing symbols in specs 2016-07-12 10:27:58 -05:00
global_milestone_spec.rb Ensure milestones passed to GlobalMilestone is an ActiveRecord::Relation 2016-09-23 13:34:39 +02:00
group_spec.rb Re-add the AccessRequestable concern 2016-09-22 11:12:17 +02:00
identity_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
issue_spec.rb Allow Member.add_user to handle access requesters 2016-09-28 09:43:00 +02:00
key_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
label_link_spec.rb
label_spec.rb Destroy related lists when a label is removed 2016-08-17 12:58:58 -03:00
legacy_diff_note_spec.rb Store discussion_id on Note for faster discussion lookup. 2016-08-17 12:16:46 -05:00
list_spec.rb Add a movable scope and a movable? method to List model 2016-08-17 12:58:59 -03:00
member_spec.rb Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master' 2016-10-02 11:42:57 +00:00
merge_request_diff_spec.rb Add test for MergeRequestDiff#commits_sha, feedback: 2016-09-22 17:36:43 +08:00
merge_request_spec.rb Improve how MergeCommit#merge_commit_message builds the message 2016-09-27 14:04:41 +02:00
milestone_spec.rb Allowing ">" to be used for Milestone models's title and storing the value in db as unescaped. 2016-09-29 19:28:38 -07:00
namespace_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
note_spec.rb remove Ability.abilities 2016-08-30 11:35:06 -07:00
notification_setting_spec.rb Exclude projects pending delete from notifications 2016-07-07 20:49:17 +01:00
personal_access_token_spec.rb
project_feature_spec.rb Project tools visibility level 2016-09-01 11:47:59 -03:00
project_group_link_spec.rb
project_snippet_spec.rb
project_spec.rb Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master' 2016-10-02 11:42:57 +00:00
project_team_spec.rb Fix specs that requires an access request 2016-09-22 11:12:17 +02:00
project_wiki_spec.rb
protected_branch_spec.rb Support wildcard matches for protected branches at the model level. 2016-07-05 10:50:34 +05:30
release_spec.rb
repository_spec.rb Add optional 'author' param when making commits 2016-09-19 10:00:26 -07:00
service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
snippet_spec.rb Snippets get award emoji! 👍 2016-09-19 19:47:43 +03:00
spam_log_spec.rb
todo_spec.rb
tree_spec.rb
user_agent_detail_spec.rb Further refactor and syntax fixes. 2016-08-15 17:20:57 -05:00
user_spec.rb Project tools visibility level 2016-09-01 11:47:59 -03:00
wiki_page_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00