0ce6785851
Replaces all the explicit include metadata syntax in the specs (tag: true) into the implicit one (:tag). Added a cop to prevent future errors and handle autocorrection.
199 lines
6.6 KiB
Ruby
199 lines
6.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'Edit Project Settings' do
|
|
include Select2Helper
|
|
|
|
let(:user) { create(:user) }
|
|
let(:project) { create(:project, namespace: user.namespace, path: 'gitlab', name: 'sample') }
|
|
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
describe 'Project settings section', :js do
|
|
it 'shows errors for invalid project name' do
|
|
visit edit_project_path(project)
|
|
fill_in 'project_name_edit', with: 'foo&bar'
|
|
page.within('.general-settings') do
|
|
click_button 'Save changes'
|
|
end
|
|
expect(page).to have_field 'project_name_edit', with: 'foo&bar'
|
|
expect(page).to have_content "Name can contain only letters, digits, emojis, '_', '.', dash, space. It must start with letter, digit, emoji or '_'."
|
|
expect(page).to have_button 'Save changes'
|
|
end
|
|
|
|
it 'shows a successful notice when the project is updated' do
|
|
visit edit_project_path(project)
|
|
fill_in 'project_name_edit', with: 'hello world'
|
|
page.within('.general-settings') do
|
|
click_button 'Save changes'
|
|
end
|
|
expect(page).to have_content "Project 'hello world' was successfully updated."
|
|
end
|
|
end
|
|
|
|
describe 'Merge request settings section' do
|
|
it 'shows "Merge commit" strategy' do
|
|
visit edit_project_path(project)
|
|
|
|
page.within '.merge-requests-feature' do
|
|
expect(page).to have_content 'Merge commit'
|
|
end
|
|
end
|
|
|
|
it 'shows "Merge commit with semi-linear history " strategy' do
|
|
visit edit_project_path(project)
|
|
|
|
page.within '.merge-requests-feature' do
|
|
expect(page).to have_content 'Merge commit with semi-linear history'
|
|
end
|
|
end
|
|
|
|
it 'shows "Fast-forward merge" strategy' do
|
|
visit edit_project_path(project)
|
|
|
|
page.within '.merge-requests-feature' do
|
|
expect(page).to have_content 'Fast-forward merge'
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Rename repository section' do
|
|
context 'with invalid characters' do
|
|
it 'shows errors for invalid project path/name' do
|
|
rename_project(project, name: 'foo&bar', path: 'foo&bar')
|
|
expect(page).to have_field 'Project name', with: 'foo&bar'
|
|
expect(page).to have_field 'Path', with: 'foo&bar'
|
|
expect(page).to have_content "Name can contain only letters, digits, emojis, '_', '.', dash, space. It must start with letter, digit, emoji or '_'."
|
|
expect(page).to have_content "Path can contain only letters, digits, '_', '-' and '.'. Cannot start with '-', end in '.git' or end in '.atom'"
|
|
end
|
|
end
|
|
|
|
context 'when changing project name' do
|
|
it 'renames the repository' do
|
|
rename_project(project, name: 'bar')
|
|
expect(find('.breadcrumbs')).to have_content(project.name)
|
|
end
|
|
|
|
context 'with emojis' do
|
|
it 'shows error for invalid project name' do
|
|
rename_project(project, name: '🚀 foo bar ☁️')
|
|
expect(page).to have_field 'Project name', with: '🚀 foo bar ☁️'
|
|
expect(page).not_to have_content "Name can contain only letters, digits, emojis '_', '.', dash and space. It must start with letter, digit, emoji or '_'."
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when changing project path' do
|
|
let(:project) { create(:project, :repository, namespace: user.namespace, name: 'gitlabhq') }
|
|
|
|
before(:context) do
|
|
TestEnv.clean_test_path
|
|
end
|
|
|
|
after do
|
|
TestEnv.clean_test_path
|
|
end
|
|
|
|
specify 'the project is accessible via the new path' do
|
|
rename_project(project, path: 'bar')
|
|
new_path = namespace_project_path(project.namespace, 'bar')
|
|
visit new_path
|
|
expect(current_path).to eq(new_path)
|
|
expect(find('.breadcrumbs')).to have_content(project.name)
|
|
end
|
|
|
|
specify 'the project is accessible via a redirect from the old path' do
|
|
old_path = project_path(project)
|
|
rename_project(project, path: 'bar')
|
|
new_path = namespace_project_path(project.namespace, 'bar')
|
|
visit old_path
|
|
expect(current_path).to eq(new_path)
|
|
expect(find('.breadcrumbs')).to have_content(project.name)
|
|
end
|
|
|
|
context 'and a new project is added with the same path' do
|
|
it 'overrides the redirect' do
|
|
old_path = project_path(project)
|
|
rename_project(project, path: 'bar')
|
|
new_project = create(:project, namespace: user.namespace, path: 'gitlabhq', name: 'quz')
|
|
visit old_path
|
|
expect(current_path).to eq(old_path)
|
|
expect(find('.breadcrumbs')).to have_content(new_project.name)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Transfer project section', :js do
|
|
let!(:project) { create(:project, :repository, namespace: user.namespace, name: 'gitlabhq') }
|
|
let!(:group) { create(:group) }
|
|
|
|
before(:context) do
|
|
TestEnv.clean_test_path
|
|
end
|
|
|
|
before do
|
|
group.add_owner(user)
|
|
end
|
|
|
|
after do
|
|
TestEnv.clean_test_path
|
|
end
|
|
|
|
specify 'the project is accessible via the new path' do
|
|
transfer_project(project, group)
|
|
new_path = namespace_project_path(group, project)
|
|
visit new_path
|
|
expect(current_path).to eq(new_path)
|
|
expect(find('.breadcrumbs')).to have_content(project.name)
|
|
end
|
|
|
|
specify 'the project is accessible via a redirect from the old path' do
|
|
old_path = project_path(project)
|
|
transfer_project(project, group)
|
|
new_path = namespace_project_path(group, project)
|
|
visit old_path
|
|
expect(current_path).to eq(new_path)
|
|
expect(find('.breadcrumbs')).to have_content(project.name)
|
|
end
|
|
|
|
context 'and a new project is added with the same path' do
|
|
it 'overrides the redirect' do
|
|
old_path = project_path(project)
|
|
transfer_project(project, group)
|
|
new_project = create(:project, namespace: user.namespace, path: 'gitlabhq', name: 'quz')
|
|
visit old_path
|
|
expect(current_path).to eq(old_path)
|
|
expect(find('.breadcrumbs')).to have_content(new_project.name)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def rename_project(project, name: nil, path: nil)
|
|
visit edit_project_path(project)
|
|
fill_in('project_name', with: name) if name
|
|
fill_in('Path', with: path) if path
|
|
click_button('Rename project')
|
|
wait_for_edit_project_page_reload
|
|
project.reload
|
|
end
|
|
|
|
def transfer_project(project, namespace)
|
|
visit edit_project_path(project)
|
|
select2(namespace.id, from: '#new_namespace_id')
|
|
click_button('Transfer project')
|
|
confirm_transfer_modal
|
|
wait_for_edit_project_page_reload
|
|
project.reload
|
|
end
|
|
|
|
def confirm_transfer_modal
|
|
fill_in('confirm_name_input', with: project.path)
|
|
click_button 'Confirm'
|
|
end
|
|
|
|
def wait_for_edit_project_page_reload
|
|
expect(find('.project-edit-container')).to have_content('Rename repository')
|
|
end
|