6ef87a2083
Having two states that essentially mean the same thing is very much like
having a boolean "true" and boolean "mostly-true": it's rather silly.
This commit merges the "reopened" state into the "opened" state while
taking care of system notes still showing messages along the lines of
"Alice reopened this issue".
A big benefit from having only two states (opened and closed) is that
indexing and querying becomes simpler and more performant. For example,
to get all the opened queries we no longer have to query both states:
SELECT *
FROM issues
WHERE project_id = 2
AND state IN ('opened', 'reopened');
Instead we can query a single state directly, which can be much faster:
SELECT *
FROM issues
WHERE project_id = 2
AND state = 'opened';
Further, only having two states makes indexing easier as we will only
ever filter (and thus scan an index) using a single value. Partial
indexes could help but aren't supported on MySQL, complicating the
development process and not being helpful for MySQL.
120 lines
3.2 KiB
Ruby
120 lines
3.2 KiB
Ruby
class DroneCiService < CiService
|
|
include ReactiveService
|
|
|
|
prop_accessor :drone_url, :token
|
|
boolean_accessor :enable_ssl_verification
|
|
|
|
validates :drone_url, presence: true, url: true, if: :activated?
|
|
validates :token, presence: true, if: :activated?
|
|
|
|
after_save :compose_service_hook, if: :activated?
|
|
|
|
def compose_service_hook
|
|
hook = service_hook || build_service_hook
|
|
# If using a service template, project may not be available
|
|
hook.url = [drone_url, "/api/hook", "?owner=#{project.namespace.full_path}", "&name=#{project.path}", "&access_token=#{token}"].join if project
|
|
hook.enable_ssl_verification = !!enable_ssl_verification
|
|
hook.save
|
|
end
|
|
|
|
def execute(data)
|
|
case data[:object_kind]
|
|
when 'push'
|
|
service_hook.execute(data) if push_valid?(data)
|
|
when 'merge_request'
|
|
service_hook.execute(data) if merge_request_valid?(data)
|
|
when 'tag_push'
|
|
service_hook.execute(data) if tag_push_valid?(data)
|
|
end
|
|
end
|
|
|
|
def allow_target_ci?
|
|
true
|
|
end
|
|
|
|
def self.supported_events
|
|
%w(push merge_request tag_push)
|
|
end
|
|
|
|
def commit_status_path(sha, ref)
|
|
url = [drone_url,
|
|
"gitlab/#{project.full_path}/commits/#{sha}",
|
|
"?branch=#{URI.encode(ref.to_s)}&access_token=#{token}"]
|
|
|
|
URI.join(*url).to_s
|
|
end
|
|
|
|
def commit_status(sha, ref)
|
|
with_reactive_cache(sha, ref) {|cached| cached[:commit_status] }
|
|
end
|
|
|
|
def calculate_reactive_cache(sha, ref)
|
|
response = HTTParty.get(commit_status_path(sha, ref), verify: enable_ssl_verification)
|
|
|
|
status =
|
|
if response.code == 200 && response['status']
|
|
case response['status']
|
|
when 'killed'
|
|
:canceled
|
|
when 'failure', 'error'
|
|
# Because drone return error if some test env failed
|
|
:failed
|
|
else
|
|
response["status"]
|
|
end
|
|
else
|
|
:error
|
|
end
|
|
|
|
{ commit_status: status }
|
|
rescue Errno::ECONNREFUSED
|
|
{ commit_status: :error }
|
|
end
|
|
|
|
def build_page(sha, ref)
|
|
url = [drone_url,
|
|
"gitlab/#{project.full_path}/redirect/commits/#{sha}",
|
|
"?branch=#{URI.encode(ref.to_s)}"]
|
|
|
|
URI.join(*url).to_s
|
|
end
|
|
|
|
def title
|
|
'Drone CI'
|
|
end
|
|
|
|
def description
|
|
'Drone is a Continuous Integration platform built on Docker, written in Go'
|
|
end
|
|
|
|
def self.to_param
|
|
'drone_ci'
|
|
end
|
|
|
|
def fields
|
|
[
|
|
{ type: 'text', name: 'token', placeholder: 'Drone CI project specific token', required: true },
|
|
{ type: 'text', name: 'drone_url', placeholder: 'http://drone.example.com', required: true },
|
|
{ type: 'checkbox', name: 'enable_ssl_verification', title: "Enable SSL verification" }
|
|
]
|
|
end
|
|
|
|
private
|
|
|
|
def tag_push_valid?(data)
|
|
data[:total_commits_count] > 0 && !Gitlab::Git.blank_ref?(data[:after])
|
|
end
|
|
|
|
def push_valid?(data)
|
|
opened_merge_requests = project.merge_requests.opened.where(source_project_id: project.id,
|
|
source_branch: Gitlab::Git.ref_name(data[:ref]))
|
|
|
|
opened_merge_requests.empty? && data[:total_commits_count] > 0 &&
|
|
!Gitlab::Git.blank_ref?(data[:after])
|
|
end
|
|
|
|
def merge_request_valid?(data)
|
|
data[:object_attributes][:state] == 'opened' &&
|
|
data[:object_attributes][:merge_status] == 'unchecked'
|
|
end
|
|
end
|