gitlab-org--gitlab-foss/changelogs/unreleased/sh-fix-snippet-visibility-api.yml at c0733f43a65741b60ffceab6811341e906d17e8c - kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss - Forgejo by Causa Arcana

kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss

Stan Hu 680f437715 Fix snippets API not working with visibility level

When a restricted visibility level of `private` is set in the instance,
creating a snippet with the `visibility` level would always fail.
This happened because:

1. `params[:visibility]` was a string (e.g. "public")
2. `CreateSnippetService` and `UpdateSnippetService` only looked
   at `params[:visibility_level]`, which was `nil`.

To fix this, we:

1. Make `CreateSnippetService` look at the newly-built
   `snippet.visibility_level`, since the right value is assigned by the
   `VisibilityLevel#visibility=` method.
2. Modify `UpdateSnippetService` to handle both `visibility_level` and
`visibility` parameters.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66050

2019-08-28 22:49:58 -07:00

5 lines

103 B

YAML

Raw Blame History

 ---
 title: Fix snippets API not working with visibility level
 merge_request: 32286
 author:
 type: fixed