gitlab-org--gitlab-foss/spec/rubocop/cop
Sean McGivern 4ef3e3491e Add cop for has_many :through without disabled autoloading
Goldiloader is great, but has several issues with has_many :through relations:

* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18

Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
2018-04-09 12:47:04 +01:00
..
gitlab Add cop for has_many :through without disabled autoloading 2018-04-09 12:47:04 +01:00
migration Use gitlab-styles 2017-12-22 08:34:44 -06:00
rspec Introduce a new FactoriesInMigrationSpecs cop 2018-04-06 17:41:52 +02:00
include_sidekiq_worker_spec.rb Use gitlab-styles 2017-12-22 08:34:44 -06:00
line_break_around_conditional_block_spec.rb Adds Rubocop rule for line break around conditionals 2018-01-11 16:34:01 +00:00
project_path_helper_spec.rb Use gitlab-styles 2017-12-22 08:34:44 -06:00
sidekiq_options_queue_spec.rb Use gitlab-styles 2017-12-22 08:34:44 -06:00