81 lines
2.8 KiB
Ruby
81 lines
2.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe 'Merge request > User scrolls to note on load', :js do
|
|
let(:project) { create(:project, :public, :repository) }
|
|
let(:user) { project.creator }
|
|
let(:merge_request) { create(:merge_request, source_project: project, author: user) }
|
|
let(:note) { create(:diff_note_on_merge_request, noteable: merge_request, project: project) }
|
|
let(:fragment_id) { "#note_#{note.id}" }
|
|
|
|
before do
|
|
sign_in(user)
|
|
page.current_window.resize_to(1000, 300)
|
|
end
|
|
|
|
it 'scrolls note into view' do
|
|
visit "#{project_merge_request_path(project, merge_request)}#{fragment_id}"
|
|
|
|
wait_for_all_requests
|
|
|
|
expect(page).to have_selector("#{fragment_id}")
|
|
|
|
page_scroll_y = page.evaluate_script("window.scrollY")
|
|
fragment_position_top = page.evaluate_script("Math.round(document.querySelector('#{fragment_id}').getBoundingClientRect().top + window.pageYOffset)")
|
|
|
|
expect(find(fragment_id).visible?).to eq true
|
|
expect(fragment_position_top).to be >= page_scroll_y
|
|
expect(page.evaluate_script("window.pageYOffset")).to be > 0
|
|
end
|
|
|
|
it 'renders un-collapsed notes with diff' do
|
|
page.current_window.resize_to(1000, 1000)
|
|
|
|
visit "#{project_merge_request_path(project, merge_request)}#{fragment_id}"
|
|
|
|
page.execute_script "window.scrollTo(0,0)"
|
|
|
|
note_element = find(fragment_id)
|
|
note_container = note_element.ancestor('.js-discussion-container')
|
|
|
|
expect(note_element.visible?).to eq true
|
|
|
|
page.within note_container do
|
|
expect(page).not_to have_selector('.js-error-lazy-load-diff')
|
|
end
|
|
end
|
|
|
|
context 'resolved notes' do
|
|
let(:collapsed_fragment_id) { "#note_#{resolved_note.id}" }
|
|
|
|
context 'when diff note' do
|
|
let(:resolved_note) { create(:diff_note_on_merge_request, :resolved, noteable: merge_request, project: project) }
|
|
|
|
it 'expands collapsed notes' do
|
|
visit "#{project_merge_request_path(project, merge_request)}#{collapsed_fragment_id}"
|
|
|
|
note_element = find(collapsed_fragment_id)
|
|
diff_container = note_element.ancestor('.diff-content')
|
|
|
|
expect(note_element.visible?).to eq(true)
|
|
expect(diff_container.visible?).to eq(true)
|
|
end
|
|
end
|
|
|
|
context 'when non-diff note' do
|
|
let(:non_diff_discussion) { create(:discussion_note_on_merge_request, :resolved, noteable: merge_request, project: project) }
|
|
let(:resolved_note) { create(:discussion_note_on_merge_request, :resolved, noteable: merge_request, project: project, in_reply_to: non_diff_discussion) }
|
|
|
|
it 'expands collapsed replies' do
|
|
visit "#{project_merge_request_path(project, merge_request)}#{collapsed_fragment_id}"
|
|
|
|
note_element = find(collapsed_fragment_id)
|
|
|
|
expect(note_element.visible?).to eq(true)
|
|
expect(note_element.sibling('.replies-toggle')[:class]).to include('expanded')
|
|
end
|
|
end
|
|
end
|
|
end
|