bf8f4c135a
In https://github.com/rails/rails/commit/83b767ce, Rails 5.1 removed support for using a String to specify a middleware. When the strategy_class argument is passed from the GitLab YAML config to Devise, Devise passes the string value straight through to Rails, and GitLab would crash with a NoMethodError inside ActionDispatch::MiddlewareStack. To make this OmniAuth strategy work again, we normalize the arguments by converting the strategy_class value into an actual Class. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62216
87 lines
2.9 KiB
Ruby
87 lines
2.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::OmniauthInitializer do
|
|
let(:devise_config) { class_double(Devise) }
|
|
|
|
subject { described_class.new(devise_config) }
|
|
|
|
describe '#execute' do
|
|
it 'configures providers from array' do
|
|
generic_config = { 'name' => 'generic' }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:generic)
|
|
|
|
subject.execute([generic_config])
|
|
end
|
|
|
|
it 'allows "args" array for app_id and app_secret' do
|
|
legacy_config = { 'name' => 'legacy', 'args' => %w(123 abc) }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:legacy, '123', 'abc')
|
|
|
|
subject.execute([legacy_config])
|
|
end
|
|
|
|
it 'passes app_id and app_secret as additional arguments' do
|
|
twitter_config = { 'name' => 'twitter', 'app_id' => '123', 'app_secret' => 'abc' }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:twitter, '123', 'abc')
|
|
|
|
subject.execute([twitter_config])
|
|
end
|
|
|
|
it 'passes "args" hash as symbolized hash argument' do
|
|
hash_config = { 'name' => 'hash', 'args' => { 'custom' => 'format' } }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:hash, custom: 'format')
|
|
|
|
subject.execute([hash_config])
|
|
end
|
|
|
|
it 'normalizes a String strategy_class' do
|
|
hash_config = { 'name' => 'hash', 'args' => { strategy_class: 'OmniAuth::Strategies::OAuth2Generic' } }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:hash, strategy_class: OmniAuth::Strategies::OAuth2Generic)
|
|
|
|
subject.execute([hash_config])
|
|
end
|
|
|
|
it 'allows a class to be specified in strategy_class' do
|
|
hash_config = { 'name' => 'hash', 'args' => { strategy_class: OmniAuth::Strategies::OAuth2Generic } }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:hash, strategy_class: OmniAuth::Strategies::OAuth2Generic)
|
|
|
|
subject.execute([hash_config])
|
|
end
|
|
|
|
it 'throws an error for an invalid strategy_class' do
|
|
hash_config = { 'name' => 'hash', 'args' => { strategy_class: 'OmniAuth::Strategies::Bogus' } }
|
|
|
|
expect { subject.execute([hash_config]) }.to raise_error(NameError)
|
|
end
|
|
|
|
it 'configures fail_with_empty_uid for shibboleth' do
|
|
shibboleth_config = { 'name' => 'shibboleth', 'args' => {} }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:shibboleth, fail_with_empty_uid: true)
|
|
|
|
subject.execute([shibboleth_config])
|
|
end
|
|
|
|
it 'configures remote_sign_out_handler proc for authentiq' do
|
|
authentiq_config = { 'name' => 'authentiq', 'args' => {} }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:authentiq, remote_sign_out_handler: an_instance_of(Proc))
|
|
|
|
subject.execute([authentiq_config])
|
|
end
|
|
|
|
it 'configures on_single_sign_out proc for cas3' do
|
|
cas3_config = { 'name' => 'cas3', 'args' => {} }
|
|
|
|
expect(devise_config).to receive(:omniauth).with(:cas3, on_single_sign_out: an_instance_of(Proc))
|
|
|
|
subject.execute([cas3_config])
|
|
end
|
|
end
|
|
end
|