366 lines
11 KiB
Ruby
366 lines
11 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe 'Issues > User uses quick actions', :js do
|
|
include Spec::Support::Helpers::Features::NotesHelpers
|
|
|
|
it_behaves_like 'issuable record that supports quick actions in its description and notes', :issue do
|
|
let(:issuable) { create(:issue, project: project) }
|
|
end
|
|
|
|
describe 'issue-only commands' do
|
|
let(:user) { create(:user) }
|
|
let(:project) { create(:project, :public) }
|
|
|
|
before do
|
|
project.add_maintainer(user)
|
|
sign_in(user)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
after do
|
|
wait_for_requests
|
|
end
|
|
|
|
describe 'time tracking' do
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
before do
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it_behaves_like 'issuable time tracker'
|
|
end
|
|
|
|
describe 'adding a due date from note' do
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
context 'when the current user can update the due date' do
|
|
it 'does not create a note, and sets the due date accordingly' do
|
|
add_note("/due 2016-08-28")
|
|
|
|
expect(page).not_to have_content '/due 2016-08-28'
|
|
expect(page).to have_content 'Commands applied'
|
|
|
|
issue.reload
|
|
|
|
expect(issue.due_date).to eq Date.new(2016, 8, 28)
|
|
end
|
|
end
|
|
|
|
context 'when the current user cannot update the due date' do
|
|
let(:guest) { create(:user) }
|
|
before do
|
|
project.add_guest(guest)
|
|
gitlab_sign_out
|
|
sign_in(guest)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'does not create a note, and sets the due date accordingly' do
|
|
add_note("/due 2016-08-28")
|
|
|
|
expect(page).not_to have_content 'Commands applied'
|
|
|
|
issue.reload
|
|
|
|
expect(issue.due_date).to be_nil
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'removing a due date from note' do
|
|
let(:issue) { create(:issue, project: project, due_date: Date.new(2016, 8, 28)) }
|
|
|
|
context 'when the current user can update the due date' do
|
|
it 'does not create a note, and removes the due date accordingly' do
|
|
expect(issue.due_date).to eq Date.new(2016, 8, 28)
|
|
|
|
add_note("/remove_due_date")
|
|
|
|
expect(page).not_to have_content '/remove_due_date'
|
|
expect(page).to have_content 'Commands applied'
|
|
|
|
issue.reload
|
|
|
|
expect(issue.due_date).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when the current user cannot update the due date' do
|
|
let(:guest) { create(:user) }
|
|
before do
|
|
project.add_guest(guest)
|
|
gitlab_sign_out
|
|
sign_in(guest)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'does not create a note, and sets the due date accordingly' do
|
|
add_note("/remove_due_date")
|
|
|
|
expect(page).not_to have_content 'Commands applied'
|
|
|
|
issue.reload
|
|
|
|
expect(issue.due_date).to eq Date.new(2016, 8, 28)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'toggling the WIP prefix from the title from note' do
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
it 'does not recognize the command nor create a note' do
|
|
add_note("/wip")
|
|
|
|
expect(page).not_to have_content '/wip'
|
|
end
|
|
end
|
|
|
|
describe 'mark issue as duplicate' do
|
|
let(:issue) { create(:issue, project: project) }
|
|
let(:original_issue) { create(:issue, project: project) }
|
|
|
|
context 'when the current user can update issues' do
|
|
it 'does not create a note, and marks the issue as a duplicate' do
|
|
add_note("/duplicate ##{original_issue.to_reference}")
|
|
|
|
expect(page).not_to have_content "/duplicate #{original_issue.to_reference}"
|
|
expect(page).to have_content 'Commands applied'
|
|
expect(page).to have_content "marked this issue as a duplicate of #{original_issue.to_reference}"
|
|
|
|
expect(issue.reload).to be_closed
|
|
end
|
|
end
|
|
|
|
context 'when the current user cannot update the issue' do
|
|
let(:guest) { create(:user) }
|
|
before do
|
|
project.add_guest(guest)
|
|
gitlab_sign_out
|
|
sign_in(guest)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'does not create a note, and does not mark the issue as a duplicate' do
|
|
add_note("/duplicate ##{original_issue.to_reference}")
|
|
|
|
expect(page).not_to have_content 'Commands applied'
|
|
expect(page).not_to have_content "marked this issue as a duplicate of #{original_issue.to_reference}"
|
|
|
|
expect(issue.reload).to be_open
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'make issue confidential' do
|
|
let(:issue) { create(:issue, project: project) }
|
|
let(:original_issue) { create(:issue, project: project) }
|
|
|
|
context 'when the current user can update issues' do
|
|
it 'does not create a note, and marks the issue as confidential' do
|
|
add_note("/confidential")
|
|
|
|
expect(page).not_to have_content "/confidential"
|
|
expect(page).to have_content 'Commands applied'
|
|
expect(page).to have_content "made the issue confidential"
|
|
|
|
expect(issue.reload).to be_confidential
|
|
end
|
|
end
|
|
|
|
context 'when the current user cannot update the issue' do
|
|
let(:guest) { create(:user) }
|
|
before do
|
|
project.add_guest(guest)
|
|
gitlab_sign_out
|
|
sign_in(guest)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'does not create a note, and does not mark the issue as confidential' do
|
|
add_note("/confidential")
|
|
|
|
expect(page).not_to have_content 'Commands applied'
|
|
expect(page).not_to have_content "made the issue confidential"
|
|
|
|
expect(issue.reload).not_to be_confidential
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'move the issue to another project' do
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
context 'when the project is valid' do
|
|
let(:target_project) { create(:project, :public) }
|
|
|
|
before do
|
|
target_project.add_maintainer(user)
|
|
gitlab_sign_out
|
|
sign_in(user)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'moves the issue' do
|
|
add_note("/move #{target_project.full_path}")
|
|
|
|
expect(page).to have_content 'Commands applied'
|
|
expect(issue.reload).to be_closed
|
|
|
|
visit project_issue_path(target_project, issue)
|
|
|
|
expect(page).to have_content 'Issues 1'
|
|
end
|
|
end
|
|
|
|
context 'when the project is valid but the user not authorized' do
|
|
let(:project_unauthorized) { create(:project, :public) }
|
|
|
|
before do
|
|
gitlab_sign_out
|
|
sign_in(user)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'does not move the issue' do
|
|
add_note("/move #{project_unauthorized.full_path}")
|
|
|
|
wait_for_requests
|
|
|
|
expect(page).to have_content 'Commands applied'
|
|
expect(issue.reload).to be_open
|
|
end
|
|
end
|
|
|
|
context 'when the project is invalid' do
|
|
before do
|
|
gitlab_sign_out
|
|
sign_in(user)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'does not move the issue' do
|
|
add_note("/move not/valid")
|
|
|
|
expect(page).not_to have_content 'Commands applied'
|
|
expect(issue.reload).to be_open
|
|
end
|
|
end
|
|
|
|
context 'when the user issues multiple commands' do
|
|
let(:target_project) { create(:project, :public) }
|
|
let(:milestone) { create(:milestone, title: '1.0', project: project) }
|
|
let(:target_milestone) { create(:milestone, title: '1.0', project: target_project) }
|
|
let(:bug) { create(:label, project: project, title: 'bug') }
|
|
let(:wontfix) { create(:label, project: project, title: 'wontfix') }
|
|
let(:bug_target) { create(:label, project: target_project, title: 'bug') }
|
|
let(:wontfix_target) { create(:label, project: target_project, title: 'wontfix') }
|
|
|
|
before do
|
|
target_project.add_maintainer(user)
|
|
gitlab_sign_out
|
|
sign_in(user)
|
|
visit project_issue_path(project, issue)
|
|
end
|
|
|
|
it 'applies the commands to both issues and moves the issue' do
|
|
add_note("/label ~#{bug.title} ~#{wontfix.title}\n\n/milestone %\"#{milestone.title}\"\n\n/move #{target_project.full_path}")
|
|
|
|
expect(page).to have_content 'Commands applied'
|
|
expect(issue.reload).to be_closed
|
|
|
|
visit project_issue_path(target_project, issue)
|
|
|
|
expect(page).to have_content 'bug'
|
|
expect(page).to have_content 'wontfix'
|
|
expect(page).to have_content '1.0'
|
|
|
|
visit project_issue_path(project, issue)
|
|
expect(page).to have_content 'Closed'
|
|
expect(page).to have_content 'bug'
|
|
expect(page).to have_content 'wontfix'
|
|
expect(page).to have_content '1.0'
|
|
end
|
|
|
|
it 'moves the issue and applies the commands to both issues' do
|
|
add_note("/move #{target_project.full_path}\n\n/label ~#{bug.title} ~#{wontfix.title}\n\n/milestone %\"#{milestone.title}\"")
|
|
|
|
expect(page).to have_content 'Commands applied'
|
|
expect(issue.reload).to be_closed
|
|
|
|
visit project_issue_path(target_project, issue)
|
|
|
|
expect(page).to have_content 'bug'
|
|
expect(page).to have_content 'wontfix'
|
|
expect(page).to have_content '1.0'
|
|
|
|
visit project_issue_path(project, issue)
|
|
expect(page).to have_content 'Closed'
|
|
expect(page).to have_content 'bug'
|
|
expect(page).to have_content 'wontfix'
|
|
expect(page).to have_content '1.0'
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'create a merge request starting from an issue' do
|
|
let(:project) { create(:project, :public, :repository) }
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
def expect_mr_quickaction(success)
|
|
expect(page).to have_content 'Commands applied'
|
|
|
|
if success
|
|
expect(page).to have_content 'created merge request'
|
|
else
|
|
expect(page).not_to have_content 'created merge request'
|
|
end
|
|
end
|
|
|
|
it "doesn't create a merge request when the branch name is invalid" do
|
|
add_note("/create_merge_request invalid branch name")
|
|
|
|
wait_for_requests
|
|
|
|
expect_mr_quickaction(false)
|
|
end
|
|
|
|
it "doesn't create a merge request when a branch with that name already exists" do
|
|
add_note("/create_merge_request feature")
|
|
|
|
wait_for_requests
|
|
|
|
expect_mr_quickaction(false)
|
|
end
|
|
|
|
it 'creates a new merge request using issue iid and title as branch name when the branch name is empty' do
|
|
add_note("/create_merge_request")
|
|
|
|
wait_for_requests
|
|
|
|
expect_mr_quickaction(true)
|
|
|
|
created_mr = project.merge_requests.last
|
|
expect(created_mr.source_branch).to eq(issue.to_branch_name)
|
|
|
|
visit project_merge_request_path(project, created_mr)
|
|
expect(page).to have_content %{WIP: Resolve "#{issue.title}"}
|
|
end
|
|
|
|
it 'creates a merge request using the given branch name' do
|
|
branch_name = '1-feature'
|
|
add_note("/create_merge_request #{branch_name}")
|
|
|
|
expect_mr_quickaction(true)
|
|
|
|
created_mr = project.merge_requests.last
|
|
expect(created_mr.source_branch).to eq(branch_name)
|
|
|
|
visit project_merge_request_path(project, created_mr)
|
|
expect(page).to have_content %{WIP: Resolve "#{issue.title}"}
|
|
end
|
|
end
|
|
end
|
|
end
|