![]() Prior, an administrator viewing a project's Labels page would see _all_ labels from every project they had access to, rather than only the labels of that specific project (if any). This was not an information disclosure, as admins have access to everything, but it was a performance issue. |
||
---|---|---|
.. | ||
README.md | ||
access_requests_finder.rb | ||
branches_finder.rb | ||
contributed_projects_finder.rb | ||
group_projects_finder.rb | ||
groups_finder.rb | ||
issuable_finder.rb | ||
issues_finder.rb | ||
joined_groups_finder.rb | ||
labels_finder.rb | ||
merge_requests_finder.rb | ||
milestones_finder.rb | ||
move_to_project_finder.rb | ||
notes_finder.rb | ||
personal_projects_finder.rb | ||
pipelines_finder.rb | ||
projects_finder.rb | ||
snippets_finder.rb | ||
tags_finder.rb | ||
todos_finder.rb | ||
union_finder.rb |
README.md
Finders
This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:
class Project
def issues_for_user_filtered_by(user, filter)
# A lot of logic not related to project model itself
end
end
issues = project.issues_for_user_filtered_by(user, params)
Better use this:
issues = IssuesFinder.new(project, user, filter).execute
It will help keep models thiner.