6d37fe952b
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] ✅ app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] 🚥 app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] ✅ app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
59 lines
2 KiB
Ruby
59 lines
2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe CycleAnalytics::Summary, models: true do
|
|
let(:project) { create(:project) }
|
|
let(:from) { Time.now }
|
|
let(:user) { create(:user, :admin) }
|
|
subject { described_class.new(project, user, from: from) }
|
|
|
|
describe "#new_issues" do
|
|
it "finds the number of issues created after the 'from date'" do
|
|
Timecop.freeze(5.days.ago) { create(:issue, project: project) }
|
|
Timecop.freeze(5.days.from_now) { create(:issue, project: project) }
|
|
|
|
expect(subject.new_issues).to eq(1)
|
|
end
|
|
|
|
it "doesn't find issues from other projects" do
|
|
Timecop.freeze(5.days.from_now) { create(:issue, project: create(:project)) }
|
|
|
|
expect(subject.new_issues).to eq(0)
|
|
end
|
|
end
|
|
|
|
describe "#commits" do
|
|
it "finds the number of commits created after the 'from date'" do
|
|
Timecop.freeze(5.days.ago) { create_commit("Test message", project, user, 'master') }
|
|
Timecop.freeze(5.days.from_now) { create_commit("Test message", project, user, 'master') }
|
|
|
|
expect(subject.commits).to eq(1)
|
|
end
|
|
|
|
it "doesn't find commits from other projects" do
|
|
Timecop.freeze(5.days.from_now) { create_commit("Test message", create(:project), user, 'master') }
|
|
|
|
expect(subject.commits).to eq(0)
|
|
end
|
|
|
|
it "finds a large (> 100) snumber of commits if present" do
|
|
Timecop.freeze(5.days.from_now) { create_commit("Test message", project, user, 'master', count: 100) }
|
|
|
|
expect(subject.commits).to eq(100)
|
|
end
|
|
end
|
|
|
|
describe "#deploys" do
|
|
it "finds the number of deploys made created after the 'from date'" do
|
|
Timecop.freeze(5.days.ago) { create(:deployment, project: project) }
|
|
Timecop.freeze(5.days.from_now) { create(:deployment, project: project) }
|
|
|
|
expect(subject.deploys).to eq(1)
|
|
end
|
|
|
|
it "doesn't find commits from other projects" do
|
|
Timecop.freeze(5.days.from_now) { create(:deployment, project: create(:project)) }
|
|
|
|
expect(subject.deploys).to eq(0)
|
|
end
|
|
end
|
|
end
|