gitlab-org--gitlab-foss/app
Dmitriy Zaporozhets cfbff017d0 Merge branch 'you-get-a-title-and-you-get-a-title-and-everyone-gets-a-title' into 'master'
Add a page title to every page.

![You get a title, and you get a title; everyone gets a title!](https://i.imgflip.com/kvmq8.jpg)

The `page_title` helper pushes the provided string at the end of the title, but because of the order that layouts are rendered in by ActionView, the result is always this:

```
<title from view> |
<title from as specified in the controller or by its layout> |
<title from layouts/_head>
```

For example: `Merge Requests | GitLab.org / Gitlab Community Edition | GitLab`.

All a developer needs to know is to put a `page_title` call describing the page in question at the start of every template.

To get everything where I wanted it to go without too much duplication, I had to make some changes around layouts, sidebars and controllers.

See merge request !593
2015-05-02 07:34:58 +00:00
..
assets Merge branch 'you-get-a-title-and-you-get-a-title-and-everyone-gets-a-title' into 'master' 2015-05-02 07:34:58 +00:00
controllers Fix title on user page. 2015-05-01 11:33:54 +02:00
finders Fix tests and unassigned filter for issues. Updated CHANGELOG 2015-03-27 00:27:51 -07:00
helpers Merge branch 'you-get-a-title-and-you-get-a-title-and-everyone-gets-a-title' into 'master' 2015-05-02 07:34:58 +00:00
mailers Remove duplicate settings for default_url_options 2015-04-25 19:46:04 -04:00
models Improve/add specs for Project#get_issue and #issue_exists? 2015-05-01 13:29:36 -04:00
services Revert "Added X-GitLab-Event header for web hooks" 2015-04-27 16:29:31 +03:00
uploaders Fix URL to uploaded file. 2015-02-20 16:01:37 +01:00
views Fix title on user page. 2015-05-01 11:33:54 +02:00
workers Revert "Added X-GitLab-Event header for web hooks" 2015-04-27 16:29:31 +03:00