d0b8f536a1
This removes all usage of soft removals except for the "pending delete" system implemented for projects. This in turn simplifies all the query plans of the models that used soft removals. Since we don't really use soft removals for anything useful there's no point in keeping it around. This _does_ mean that hard removals of issues (which only admins can do if I'm not mistaken) can influence the "iid" values, but that code is broken to begin with. More on this (and how to fix it) can be found in https://gitlab.com/gitlab-org/gitlab-ce/issues/31114. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
44 lines
967 B
Ruby
44 lines
967 B
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::HookData::IssueBuilder do
|
|
set(:issue) { create(:issue) }
|
|
let(:builder) { described_class.new(issue) }
|
|
|
|
describe '#build' do
|
|
let(:data) { builder.build }
|
|
|
|
it 'includes safe attribute' do
|
|
%w[
|
|
assignee_id
|
|
author_id
|
|
closed_at
|
|
confidential
|
|
created_at
|
|
description
|
|
due_date
|
|
id
|
|
iid
|
|
last_edited_at
|
|
last_edited_by_id
|
|
milestone_id
|
|
moved_to_id
|
|
project_id
|
|
relative_position
|
|
state
|
|
time_estimate
|
|
title
|
|
updated_at
|
|
updated_by_id
|
|
].each do |key|
|
|
expect(data).to include(key)
|
|
end
|
|
end
|
|
|
|
it 'includes additional attrs' do
|
|
expect(data).to include(:total_time_spent)
|
|
expect(data).to include(:human_time_estimate)
|
|
expect(data).to include(:human_total_time_spent)
|
|
expect(data).to include(:assignee_ids)
|
|
end
|
|
end
|
|
end
|