kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/models
History
Rémy Coutable 2f161208d2 Merge branch 'issue_14563' into 'master' 
Fix user creation with stronger minimum password requirements

## What does this MR do?

`doc/security/password_length_limits.md` Describes a way to increase minimum requirements of passwords, via `config/initializers/devise_password_length.rb`. However, user creation hardcoded password generation at 8 characters.

If the minimum was set at any more than 8 characters, user creation will fail.

Function now looks up minimum length requirement.

## What are the relevant issue numbers?

Fixes #14563.

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4054
2016-06-23 18:18:17 +00:00
..
ci fixed pipeline notes issue 2016-06-23 12:29:11 +02:00
concerns Fix pagination on sorts with lots of ties 2016-06-23 15:26:50 +01:00
hooks Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
members New Members::DestroyService 2016-06-18 05:46:45 +02:00
network Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
project_services Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
.gitkeep
ability.rb Fix 404 for pipelines 2016-06-23 16:47:03 +02:00
abuse_report.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
appearance.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
application_setting.rb a few changes based on MR feedback 2016-06-17 15:47:00 +02:00
audit_event.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
award_emoji.rb
blob.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
broadcast_message.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
commit.rb Optimize Banzai::Filter::RelativeLinkFilter 2016-06-21 10:53:16 -04:00
commit_range.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
commit_status.rb Rename commit_data in Pipeline to commit 2016-06-21 14:43:37 +02:00
deploy_key.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
deploy_keys_project.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
deployment.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
email.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
environment.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
event.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
external_issue.rb
forked_project_link.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
generic_commit_status.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
global_label.rb
global_milestone.rb
group.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
identity.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
issue.rb Fix RangeError exceptions when referring to issues or merge requests outside of max database values 2016-06-18 13:07:38 -07:00
key.rb Remove Duplicated keys add UNIQUE index to fingerprint 2016-06-20 13:29:04 +02:00
label.rb Fix label order by priority on labels page 2016-06-07 14:01:30 +01:00
label_link.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
legacy_diff_note.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
lfs_object.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
lfs_objects_project.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
member.rb New Members::DestroyService 2016-06-18 05:46:45 +02:00
merge_request.rb Fix RangeError exceptions when referring to issues or merge requests outside of max database values 2016-06-18 13:07:38 -07:00
merge_request_diff.rb Merge branches 'feature/project-export' and 'feature/project-import' of gitlab.com:gitlab-org/gitlab-ce into feature/project-import 2016-06-13 12:43:25 +02:00
milestone.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
namespace.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
note.rb fixed merge conflicts 2016-06-16 14:07:49 +02:00
notification_setting.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
oauth_access_token.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
personal_access_token.rb
personal_snippet.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
project.rb Merge branch 'feature/project-export' into 'master' 2016-06-17 15:35:27 +00:00
project_group_link.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
project_import_data.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
project_snippet.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
project_team.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
project_wiki.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
protected_branch.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
release.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
repository.rb Improve performance of searching tags by name by using a memorized tag array 2016-06-23 12:15:58 -04:00
security_event.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
sent_notification.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
service.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
snippet.rb Remove projects inclusion in notes_with_associations to skip some unnecessary queries 2016-06-08 10:26:05 -04:00
spam_log.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
spam_report.rb
subscription.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
todo.rb Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
tree.rb
u2f_registration.rb Add a U2fRegistrations table/model. 2016-06-06 12:50:31 +05:30
user.rb Fix user creation with stronger minimum password requirements:q 2016-06-23 11:52:05 -04:00
users_star_project.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
wiki_page.rb