12db4cc0e7
Fix missing Note access checks in by moving Note#search to updated NoteFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR? ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested ### Note lookup without access check - [x] ✅ app/finders/notes_finder.rb:13 :download_code check - [x] ✅ app/finders/notes_finder.rb:19 `SnippetsFinder` - [x] ✅ app/models/note.rb:121 [`Issue#visible_to_user`] - [x] ✅ lib/gitlab/project_search_results.rb:113 - This is the only use of `app/models/note.rb:121` above, but importantly has no access checks at all. This means it leaks MR comments and snippets when those features are `team-only` in addition to the issue comments which would be fixed by `app/models/note.rb:121`. - It is only called from SearchController where `can?(current_user, :download_code, @project)` is checked, so commit comments are not leaked. ### Previous discussions - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_13_13 `: download_code` check on commit - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_19_19 `SnippetsFinder` should be used - `SnippetsFinder` should check if the snippets feature is enabled -> https://gitlab.com/gitlab-org/gitlab-ce/issues/25223 ### Acceptance criteria met? - [x] Tests added for new code - [x] TODO comments removed - [x] Squashed and removed skipped tests - [x] Changelog entry - [ ] State Gitlab versions affected and issue severity in description - [ ] Create technical debt issue for NotesFinder. - Either split into `NotesFinder::ForTarget` and `NotesFinder::Search` or consider object per notable type such as `NotesFinder::OnIssue`. For the first option could create `NotesFinder::Base` which is either inherited from or which can be included in the other two. - Avoid case statement anti-pattern in this finder with use of `NotesFinder::OnCommit` etc. Consider something on the finder for this? `Model.finder(user, project)` - Move `inc_author` to the controller, and implement `related_notes` to replace `non_diff_notes`/`mr_and_commit_notes` See merge request !2035 |
||
---|---|---|
.. | ||
boards | ||
cycle_analytics | ||
application_controller.rb | ||
artifacts_controller.rb | ||
avatars_controller.rb | ||
badges_controller.rb | ||
blame_controller.rb | ||
blob_controller.rb | ||
boards_controller.rb | ||
branches_controller.rb | ||
builds_controller.rb | ||
commit_controller.rb | ||
commits_controller.rb | ||
compare_controller.rb | ||
container_registry_controller.rb | ||
cycle_analytics_controller.rb | ||
deploy_keys_controller.rb | ||
discussions_controller.rb | ||
environments_controller.rb | ||
find_file_controller.rb | ||
forks_controller.rb | ||
git_http_client_controller.rb | ||
git_http_controller.rb | ||
graphs_controller.rb | ||
group_links_controller.rb | ||
hooks_controller.rb | ||
imports_controller.rb | ||
issues_controller.rb | ||
labels_controller.rb | ||
lfs_api_controller.rb | ||
lfs_storage_controller.rb | ||
merge_requests_controller.rb | ||
milestones_controller.rb | ||
network_controller.rb | ||
notes_controller.rb | ||
pipelines_controller.rb | ||
pipelines_settings_controller.rb | ||
project_members_controller.rb | ||
protected_branches_controller.rb | ||
raw_controller.rb | ||
refs_controller.rb | ||
releases_controller.rb | ||
repositories_controller.rb | ||
runner_projects_controller.rb | ||
runners_controller.rb | ||
services_controller.rb | ||
snippets_controller.rb | ||
tags_controller.rb | ||
templates_controller.rb | ||
todos_controller.rb | ||
tree_controller.rb | ||
triggers_controller.rb | ||
uploads_controller.rb | ||
variables_controller.rb | ||
wikis_controller.rb |