1a4d1b0501
This stopped working in GitLab 11.11 when we upgraded to Rails 5.1. Rails 5 changed ActionController::Parameters to return an Object instead of a Hash. The old behavior was deprecated in Rails 5 but finally removed in Rails 5.1 Since the controller wasn't updated properly, the callback endpoint quietly failed with the message, "Could not connect to FogBugz, check your url". To fix this, we need to call `to_h` on the `import_params` to access the Hash. We also need to do this for the user map and permit specific keys. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/33530
78 lines
2.1 KiB
Ruby
78 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Import::FogbugzController do
|
|
include ImportSpecHelper
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
describe 'POST #callback' do
|
|
let(:token) { FFaker::Lorem.characters(8) }
|
|
let(:uri) { 'https://example.com' }
|
|
let(:xml_response) { %Q(<?xml version=\"1.0\" encoding=\"UTF-8\"?><response><token><![CDATA[#{token}]]></token></response>) }
|
|
|
|
it 'attempts to contact Fogbugz server' do
|
|
stub_request(:post, "https://example.com/api.asp").to_return(status: 200, body: xml_response, headers: {})
|
|
|
|
post :callback, params: { uri: uri, email: 'test@example.com', password: 'mypassword' }
|
|
|
|
expect(session[:fogbugz_token]).to eq(token)
|
|
expect(session[:fogbugz_uri]).to eq(uri)
|
|
expect(response).to redirect_to(new_user_map_import_fogbugz_path)
|
|
end
|
|
end
|
|
|
|
describe 'POST #create_user_map' do
|
|
let(:user_map) do
|
|
{
|
|
"2" => {
|
|
"name" => "Test User",
|
|
"email" => "testuser@example.com",
|
|
"gitlab_user" => "3"
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'stores the user map in the session' do
|
|
client = double(user_map: {})
|
|
expect(controller).to receive(:client).and_return(client)
|
|
|
|
post :create_user_map, params: { users: user_map }
|
|
|
|
expect(session[:fogbugz_user_map]).to eq(user_map)
|
|
expect(response).to redirect_to(status_import_fogbugz_path)
|
|
end
|
|
end
|
|
|
|
describe 'GET status' do
|
|
before do
|
|
@repo = OpenStruct.new(name: 'vim')
|
|
stub_client(valid?: true)
|
|
end
|
|
|
|
it 'assigns variables' do
|
|
@project = create(:project, import_type: 'fogbugz', creator_id: user.id)
|
|
stub_client(repos: [@repo])
|
|
|
|
get :status
|
|
|
|
expect(assigns(:already_added_projects)).to eq([@project])
|
|
expect(assigns(:repos)).to eq([@repo])
|
|
end
|
|
|
|
it 'does not show already added project' do
|
|
@project = create(:project, import_type: 'fogbugz', creator_id: user.id, import_source: 'vim')
|
|
stub_client(repos: [@repo])
|
|
|
|
get :status
|
|
|
|
expect(assigns(:already_added_projects)).to eq([@project])
|
|
expect(assigns(:repos)).to eq([])
|
|
end
|
|
end
|
|
end
|