d3a3db4218
This commit changes how we eager-load projects, routes, and namespaces required by the deploy keys endpoint, getting a 10x improvement in my local testing. The endpoint still doesn't scale in-general, but going from ~13 seconds to dump a 63K result to generating the same thing in ~1.6 seconds seems like a good improvement to me.
54 lines
1.5 KiB
Ruby
54 lines
1.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Projects::Settings::DeployKeysPresenter do
|
|
let(:project) { create(:project) }
|
|
let(:user) { create(:user) }
|
|
let(:deploy_key) { create(:deploy_key, public: true) }
|
|
|
|
let!(:deploy_keys_project) do
|
|
create(:deploy_keys_project, project: project, deploy_key: deploy_key)
|
|
end
|
|
|
|
subject(:presenter) do
|
|
described_class.new(project, current_user: user)
|
|
end
|
|
|
|
it 'inherits from Gitlab::View::Presenter::Simple' do
|
|
expect(described_class.superclass).to eq(Gitlab::View::Presenter::Simple)
|
|
end
|
|
|
|
describe '#enabled_keys' do
|
|
it 'returns currently enabled keys' do
|
|
expect(presenter.enabled_keys).to eq [deploy_keys_project.deploy_key]
|
|
end
|
|
|
|
it 'does not contain enabled_keys inside available_keys' do
|
|
expect(presenter.available_keys).not_to include deploy_key
|
|
end
|
|
|
|
it 'returns the enabled_keys size' do
|
|
expect(presenter.enabled_keys_size).to eq(1)
|
|
end
|
|
end
|
|
|
|
describe '#available_keys/#available_project_keys' do
|
|
let(:other_deploy_key) { create(:another_deploy_key) }
|
|
|
|
before do
|
|
project_key = create(:deploy_keys_project, deploy_key: other_deploy_key)
|
|
project_key.project.add_developer(user)
|
|
end
|
|
|
|
it 'returns the current available_keys' do
|
|
expect(presenter.available_keys).not_to be_empty
|
|
end
|
|
|
|
it 'returns the current available_project_keys' do
|
|
expect(presenter.available_project_keys).not_to be_empty
|
|
end
|
|
|
|
it 'returns the available_project_keys size' do
|
|
expect(presenter.available_project_keys_size).to eq(1)
|
|
end
|
|
end
|
|
end
|