gitlab-org--gitlab-foss/spec
Douwe Maan 3803b380b4 Merge branch 'fix-git-http-routing' into 'master'
Ensure only IDs ending in .git perform git actions

## What does this MR do?

Rails's routing is pretty strange. Previously, `GET /namespace/project/info/refs` would go to the Git HTTP controller (if the redirect for that case was taken out).

## Are there points in the code the reviewer needs to double check?

The specs fail if the redirect is moved to above the Git HTTP routes, removed altogether, or the Git HTTP constraints are changed. But there might still be missing cases.

## Why was this MR needed?

The master build and HTTP cloning were both broken.

## What are the relevant issue numbers?

Closes #18376.

## Screenshots (if relevant)

Nope.

## Does this MR meet the acceptance criteria?

- [x] [not needed] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [not needed] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] (not needed) API support added
- [ ] Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4558
2016-06-09 15:01:10 +00:00
..
config
controllers Remove require_relative 'import_spec_helper' 2016-06-08 18:18:49 +02:00
factories Merge branch '18019-fix-wiki-linking' into 'master' 2016-06-09 08:37:27 +00:00
features Merge branch '18019-fix-wiki-linking' into 'master' 2016-06-09 08:37:27 +00:00
finders
fixtures Set target="_blank" for external links 2016-06-08 13:07:20 -05:00
helpers Merge branch '18019-fix-wiki-linking' into 'master' 2016-06-09 08:37:27 +00:00
initializers
javascripts Merge branch 'notes-are-awardables' into 'master' 2016-06-06 16:48:35 +00:00
lib Merge branch 'saml-ldap-link-flow' into 'master' 2016-06-09 10:48:31 +00:00
mailers Update tests for the current_application_settings request store changes 2016-05-27 19:05:52 -07:00
models Fix pseudo n+1 queries with Note and Note Authors in issuables APIs 2016-06-08 10:26:05 -04:00
requests Add test for getting info/refs from repo 2016-06-09 14:26:52 +01:00
routing
services Make Omniauth providers specs to not modify global configuration 2016-06-08 16:50:05 +02:00
support Merge branch 'make-omniauth-tests-to-not-modify-global-state' into 'master' 2016-06-09 09:55:14 +00:00
tasks/gitlab Switch the gitlab:db:configure task to use tables.any? instead of looking specifically for the schema_migrations table 2016-05-25 10:47:09 -07:00
views
workers Rename all `[ci_]commit` to `[ci_]pipeline` in specs and features 2016-06-03 16:22:26 +02:00
factories_spec.rb Enable RSpec/NotToNot cop and auto-correct offenses 2016-05-24 15:40:29 -04:00
rails_helper.rb
spec_helper.rb Enable Knapsack only in CI environment 2016-06-08 11:43:13 +02:00
teaspoon_env.rb Add leading comment space cop 2016-05-31 19:33:46 -03:00