2f2b0ad390
AES-256-GCM cipher mode requires a key that is exactly 32 bytes long. We already handle the case when the key is too long, by truncating, but the key can also be too short in some installations. Switching to a key that is always exactly the right length (by virtue of right-padding ASCII 0 characters) allows encryption to proceed, without breaking backward compatibility. When the key is too short, encryption fails with an `ArgumentError`, causing the web hooks functionality to be unusable. As a result, zero rows can exist with values encrypted with the too-short key. When the key is too long, it is silently truncated. In this case, the key is unchanged, so values encrypted with the new too-long key will still be successfully decrypted.
40 lines
1.3 KiB
Ruby
40 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class WebHook < ActiveRecord::Base
|
|
include Sortable
|
|
|
|
attr_encrypted :token,
|
|
mode: :per_attribute_iv,
|
|
algorithm: 'aes-256-gcm',
|
|
key: Settings.attr_encrypted_db_key_base_32
|
|
|
|
attr_encrypted :url,
|
|
mode: :per_attribute_iv,
|
|
algorithm: 'aes-256-gcm',
|
|
key: Settings.attr_encrypted_db_key_base_32
|
|
|
|
has_many :web_hook_logs, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
|
|
|
|
validates :url, presence: true, public_url: { allow_localhost: lambda(&:allow_local_requests?),
|
|
allow_local_network: lambda(&:allow_local_requests?) }
|
|
|
|
validates :token, format: { without: /\n/ }
|
|
validates :push_events_branch_filter, branch_filter: true
|
|
|
|
# rubocop: disable CodeReuse/ServiceClass
|
|
def execute(data, hook_name)
|
|
WebHookService.new(self, data, hook_name).execute
|
|
end
|
|
# rubocop: enable CodeReuse/ServiceClass
|
|
|
|
# rubocop: disable CodeReuse/ServiceClass
|
|
def async_execute(data, hook_name)
|
|
WebHookService.new(self, data, hook_name).async_execute
|
|
end
|
|
# rubocop: enable CodeReuse/ServiceClass
|
|
|
|
# Allow urls pointing localhost and the local network
|
|
def allow_local_requests?
|
|
false
|
|
end
|
|
end
|