gitlab-org--gitlab-foss/app/models/project_services
Yorick Peterse b4ee6f57b9 Greatly improve external_issue_tracker performance
This greatly improves the performance of Project#external_issue_tracker
by moving most of the fields queried in Ruby to the database and letting
the database handle all logic. Prior to this change the process of
finding an external issue tracker was along the lines of the following:

1. Load all project services into memory.
2. Reduce the list to only services where "issue_tracker?" returns true
3. Reduce the list from step 2 to service where "default?" returns false
4. Find the first service where "activated?" returns true

This has to two big problems:

1. Loading all services into memory only to reduce the list down to a
   single item later on is a waste of memory (and slow timing wise).
2. Calling Array#select followed by Array#reject followed by Array#find
   allocates extra objects when this really isn't needed.

To work around this the following service fields have been moved to the
database (instead of being hardcoded):

* category
* default

This in turn means we can get the external issue tracker using the
following query:

    SELECT *
    FROM services
    WHERE active IS TRUE
    AND default IS FALSE
    AND category = 'issue_tracker'
    AND project_id = XXX
    LIMIT 1

This coupled with memoizing the result (just as before this commit)
greatly reduces the time it takes for Project#external_issue_tracker to
complete. The exact reduction depends on one's environment, but locally
the execution time is reduced from roughly 230 ms to only 2 ms (= a
reduction of almost 180x).

Fixes gitlab-org/gitlab-ce#10771
2016-01-19 14:03:20 +01:00
..
slack_service Migrate CI::Services and CI::WebHooks to Services and WebHooks 2015-12-10 16:04:08 +01:00
asana_service.rb Annotate models 2016-01-06 13:09:55 +00:00
assembla_service.rb Annotate models 2016-01-06 13:09:55 +00:00
bamboo_service.rb Annotate models 2016-01-06 13:09:55 +00:00
buildkite_service.rb Annotate models 2016-01-06 13:09:55 +00:00
builds_email_service.rb Suppress e-mails on failed builds if allow_failure is set 2016-01-07 10:45:39 -08:00
campfire_service.rb Annotate models 2016-01-06 13:09:55 +00:00
ci_service.rb Greatly improve external_issue_tracker performance 2016-01-19 14:03:20 +01:00
custom_issue_tracker_service.rb Annotate models 2016-01-06 13:09:55 +00:00
drone_ci_service.rb Annotate models 2016-01-06 13:09:55 +00:00
emails_on_push_service.rb Annotate models 2016-01-06 13:09:55 +00:00
external_wiki_service.rb Annotate models 2016-01-06 13:09:55 +00:00
flowdock_service.rb Annotate models 2016-01-06 13:09:55 +00:00
gemnasium_service.rb Annotate models 2016-01-06 13:09:55 +00:00
gitlab_ci_service.rb Annotate models 2016-01-06 13:09:55 +00:00
gitlab_issue_tracker_service.rb Greatly improve external_issue_tracker performance 2016-01-19 14:03:20 +01:00
hipchat_service.rb Use CGI.escape instead of URI.escape, because URI is obsoleted. 2016-01-12 18:20:03 +08:00
irker_service.rb Mention channel/key bug in irkerd docs 2016-01-12 15:54:09 -07:00
issue_tracker_service.rb Greatly improve external_issue_tracker performance 2016-01-19 14:03:20 +01:00
jira_service.rb Merge branch 'fix_jira_shortterm' into 'master' 2016-01-10 22:12:10 +00:00
pivotaltracker_service.rb Annotate models 2016-01-06 13:09:55 +00:00
pushover_service.rb Annotate models 2016-01-06 13:09:55 +00:00
redmine_service.rb Annotate models 2016-01-06 13:09:55 +00:00
slack_service.rb Annotate models 2016-01-06 13:09:55 +00:00
teamcity_service.rb Annotate models 2016-01-06 13:09:55 +00:00