cb8a425ba4
There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893 |
||
---|---|---|
.. | ||
admin | ||
ci | ||
concerns | ||
dashboard | ||
explore | ||
groups | ||
import | ||
oauth | ||
profiles | ||
projects | ||
sherlock | ||
abuse_reports_controller.rb | ||
application_controller.rb | ||
autocomplete_controller.rb | ||
confirmations_controller.rb | ||
dashboard_controller.rb | ||
emojis_controller.rb | ||
groups_controller.rb | ||
health_check_controller.rb | ||
help_controller.rb | ||
invites_controller.rb | ||
jwt_controller.rb | ||
namespaces_controller.rb | ||
notification_settings_controller.rb | ||
omniauth_callbacks_controller.rb | ||
passwords_controller.rb | ||
profiles_controller.rb | ||
projects_controller.rb | ||
registrations_controller.rb | ||
root_controller.rb | ||
search_controller.rb | ||
sent_notifications_controller.rb | ||
sessions_controller.rb | ||
snippets_controller.rb | ||
uploads_controller.rb | ||
users_controller.rb |