509910b89f
This moves the code used for processing commits from GitPushService to its own Sidekiq worker: ProcessCommitWorker. Using a Sidekiq worker allows us to process multiple commits in parallel. This in turn will lead to issues being closed faster and cross references being created faster. Furthermore by isolating this code into a separate class it's easier to test and maintain the code. The new worker also ensures it can efficiently check which issues can be closed, without having to run numerous SQL queries for every issue.
42 lines
1.4 KiB
Ruby
42 lines
1.4 KiB
Ruby
module Issues
|
|
class CloseService < Issues::BaseService
|
|
# Closes the supplied issue if the current user is able to do so.
|
|
def execute(issue, commit: nil, notifications: true, system_note: true)
|
|
return issue unless can?(current_user, :update_issue, issue)
|
|
|
|
close_issue(issue,
|
|
commit: commit,
|
|
notifications: notifications,
|
|
system_note: system_note)
|
|
end
|
|
|
|
# Closes the supplied issue without checking if the user is authorized to
|
|
# do so.
|
|
#
|
|
# The code calling this method is responsible for ensuring that a user is
|
|
# allowed to close the given issue.
|
|
def close_issue(issue, commit: nil, notifications: true, system_note: true)
|
|
if project.jira_tracker? && project.jira_service.active
|
|
project.jira_service.execute(commit, issue)
|
|
todo_service.close_issue(issue, current_user)
|
|
return issue
|
|
end
|
|
|
|
if project.default_issues_tracker? && issue.close
|
|
event_service.close_issue(issue, current_user)
|
|
create_note(issue, commit) if system_note
|
|
notification_service.close_issue(issue, current_user) if notifications
|
|
todo_service.close_issue(issue, current_user)
|
|
execute_hooks(issue, 'close')
|
|
end
|
|
|
|
issue
|
|
end
|
|
|
|
private
|
|
|
|
def create_note(issue, current_commit)
|
|
SystemNoteService.change_status(issue, issue.project, current_user, issue.state, current_commit)
|
|
end
|
|
end
|
|
end
|