54ec7e9599
1. Make the "subscribed" text in Issuable sidebar reflect the labels subscription status 2. Current user mut be logged-in to toggle issue/MR/label subscription
546 lines
18 KiB
Ruby
546 lines
18 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe NotificationService, services: true do
|
|
let(:notification) { NotificationService.new }
|
|
|
|
around(:each) do |example|
|
|
perform_enqueued_jobs do
|
|
example.run
|
|
end
|
|
end
|
|
|
|
describe 'Keys' do
|
|
describe :new_key do
|
|
let!(:key) { create(:personal_key) }
|
|
|
|
it { expect(notification.new_key(key)).to be_truthy }
|
|
|
|
it 'should sent email to key owner' do
|
|
expect{ notification.new_key(key) }.to change{ ActionMailer::Base.deliveries.size }.by(1)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Email' do
|
|
describe :new_email do
|
|
let!(:email) { create(:email) }
|
|
|
|
it { expect(notification.new_email(email)).to be_truthy }
|
|
|
|
it 'should send email to email owner' do
|
|
expect{ notification.new_email(email) }.to change{ ActionMailer::Base.deliveries.size }.by(1)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Notes' do
|
|
context 'issue note' do
|
|
let(:project) { create(:empty_project, :private) }
|
|
let(:issue) { create(:issue, project: project, assignee: create(:user)) }
|
|
let(:mentioned_issue) { create(:issue, assignee: issue.assignee) }
|
|
let(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@mention referenced, @outsider also') }
|
|
|
|
before do
|
|
build_team(note.project)
|
|
project.team << [issue.author, :master]
|
|
project.team << [issue.assignee, :master]
|
|
project.team << [note.author, :master]
|
|
create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@subscribed_participant cc this guy')
|
|
end
|
|
|
|
describe :new_note do
|
|
it do
|
|
add_users_with_subscription(note.project, issue)
|
|
|
|
# Ensure create SentNotification by noteable = issue 6 times, not noteable = note
|
|
expect(SentNotification).to receive(:record).with(issue, any_args).exactly(7).times
|
|
|
|
ActionMailer::Base.deliveries.clear
|
|
|
|
notification.new_note(note)
|
|
|
|
should_email(@u_watcher)
|
|
should_email(note.noteable.author)
|
|
should_email(note.noteable.assignee)
|
|
should_email(@u_mentioned)
|
|
should_email(@subscriber)
|
|
should_email(@watcher_and_subscriber)
|
|
should_email(@subscribed_participant)
|
|
should_not_email(note.author)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_outsider_mentioned)
|
|
end
|
|
|
|
it 'filters out "mentioned in" notes' do
|
|
mentioned_note = SystemNoteService.cross_reference(mentioned_issue, issue, issue.author)
|
|
|
|
expect(Notify).not_to receive(:note_issue_email)
|
|
notification.new_note(mentioned_note)
|
|
end
|
|
end
|
|
|
|
describe 'new note on issue in project that belongs to a group' do
|
|
let(:group) { create(:group) }
|
|
|
|
before do
|
|
note.project.namespace_id = group.id
|
|
note.project.group.add_user(@u_watcher, GroupMember::MASTER)
|
|
note.project.save
|
|
user_project = note.project.project_members.find_by_user_id(@u_watcher.id)
|
|
user_project.notification_level = Notification::N_PARTICIPATING
|
|
user_project.save
|
|
group_member = note.project.group.group_members.find_by_user_id(@u_watcher.id)
|
|
group_member.notification_level = Notification::N_GLOBAL
|
|
group_member.save
|
|
ActionMailer::Base.deliveries.clear
|
|
end
|
|
|
|
it do
|
|
notification.new_note(note)
|
|
|
|
should_email(note.noteable.author)
|
|
should_email(note.noteable.assignee)
|
|
should_email(@u_mentioned)
|
|
should_not_email(@u_watcher)
|
|
should_not_email(note.author)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'issue note mention' do
|
|
let(:project) { create(:empty_project, :public) }
|
|
let(:issue) { create(:issue, project: project, assignee: create(:user)) }
|
|
let(:mentioned_issue) { create(:issue, assignee: issue.assignee) }
|
|
let(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@all mentioned') }
|
|
|
|
before do
|
|
build_team(note.project)
|
|
note.project.team << [note.author, :master]
|
|
ActionMailer::Base.deliveries.clear
|
|
end
|
|
|
|
describe :new_note do
|
|
it do
|
|
notification.new_note(note)
|
|
|
|
# Notify all team members
|
|
note.project.team.members.each do |member|
|
|
# User with disabled notification should not be notified
|
|
next if member.id == @u_disabled.id
|
|
# Author should not be notified
|
|
next if member.id == note.author.id
|
|
should_email(member)
|
|
end
|
|
|
|
should_email(note.noteable.author)
|
|
should_email(note.noteable.assignee)
|
|
should_not_email(note.author)
|
|
should_email(@u_mentioned)
|
|
should_not_email(@u_disabled)
|
|
should_email(@u_not_mentioned)
|
|
end
|
|
|
|
it 'filters out "mentioned in" notes' do
|
|
mentioned_note = SystemNoteService.cross_reference(mentioned_issue, issue, issue.author)
|
|
|
|
expect(Notify).not_to receive(:note_issue_email)
|
|
notification.new_note(mentioned_note)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'commit note' do
|
|
let(:project) { create(:project, :public) }
|
|
let(:note) { create(:note_on_commit, project: project) }
|
|
|
|
before do
|
|
build_team(note.project)
|
|
ActionMailer::Base.deliveries.clear
|
|
allow_any_instance_of(Commit).to receive(:author).and_return(@u_committer)
|
|
end
|
|
|
|
describe :new_note, :perform_enqueued_jobs do
|
|
it do
|
|
notification.new_note(note)
|
|
|
|
should_email(@u_committer)
|
|
should_email(@u_watcher)
|
|
should_not_email(@u_mentioned)
|
|
should_not_email(note.author)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it do
|
|
note.update_attribute(:note, '@mention referenced')
|
|
notification.new_note(note)
|
|
|
|
should_email(@u_committer)
|
|
should_email(@u_watcher)
|
|
should_email(@u_mentioned)
|
|
should_not_email(note.author)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it do
|
|
@u_committer.update_attributes(notification_level: Notification::N_MENTION)
|
|
notification.new_note(note)
|
|
should_not_email(@u_committer)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Issues' do
|
|
let(:project) { create(:empty_project, :public) }
|
|
let(:issue) { create :issue, project: project, assignee: create(:user), description: 'cc @participant' }
|
|
|
|
before do
|
|
build_team(issue.project)
|
|
add_users_with_subscription(issue.project, issue)
|
|
ActionMailer::Base.deliveries.clear
|
|
end
|
|
|
|
describe :new_issue do
|
|
it do
|
|
notification.new_issue(issue, @u_disabled)
|
|
|
|
should_email(issue.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_not_email(@u_mentioned)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it do
|
|
issue.assignee.update_attributes(notification_level: Notification::N_MENTION)
|
|
notification.new_issue(issue, @u_disabled)
|
|
|
|
should_not_email(issue.assignee)
|
|
end
|
|
|
|
it "emails subscribers of the issue's labels" do
|
|
subscriber = create(:user)
|
|
label = create(:label, issues: [issue])
|
|
label.toggle_subscription(subscriber)
|
|
notification.new_issue(issue, @u_disabled)
|
|
|
|
should_email(subscriber)
|
|
end
|
|
end
|
|
|
|
describe :reassigned_issue do
|
|
it 'emails new assignee' do
|
|
notification.reassigned_issue(issue, @u_disabled)
|
|
|
|
should_email(issue.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it 'emails previous assignee even if he has the "on mention" notif level' do
|
|
issue.update_attribute(:assignee, @u_mentioned)
|
|
issue.update_attributes(assignee: @u_watcher)
|
|
notification.reassigned_issue(issue, @u_disabled)
|
|
|
|
should_email(@u_mentioned)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it 'emails new assignee even if he has the "on mention" notif level' do
|
|
issue.update_attributes(assignee: @u_mentioned)
|
|
notification.reassigned_issue(issue, @u_disabled)
|
|
|
|
expect(issue.assignee).to be @u_mentioned
|
|
should_email(issue.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it 'emails new assignee' do
|
|
issue.update_attribute(:assignee, @u_mentioned)
|
|
notification.reassigned_issue(issue, @u_disabled)
|
|
|
|
expect(issue.assignee).to be @u_mentioned
|
|
should_email(issue.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it 'does not email new assignee if they are the current user' do
|
|
issue.update_attribute(:assignee, @u_mentioned)
|
|
notification.reassigned_issue(issue, @u_mentioned)
|
|
|
|
expect(issue.assignee).to be @u_mentioned
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_not_email(issue.assignee)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
|
|
describe '#relabeled_issue' do
|
|
let(:label) { create(:label, issues: [issue]) }
|
|
let(:label2) { create(:label) }
|
|
let!(:subscriber_to_label) { create(:user).tap { |u| label.toggle_subscription(u) } }
|
|
let!(:subscriber_to_label2) { create(:user).tap { |u| label2.toggle_subscription(u) } }
|
|
|
|
it "emails subscribers of the issue's added labels only" do
|
|
notification.relabeled_issue(issue, [label2], @u_disabled)
|
|
|
|
should_not_email(subscriber_to_label)
|
|
should_email(subscriber_to_label2)
|
|
end
|
|
|
|
it "doesn't send email to anyone but subscribers of the given labels" do
|
|
notification.relabeled_issue(issue, [label2], @u_disabled)
|
|
|
|
should_not_email(issue.assignee)
|
|
should_not_email(issue.author)
|
|
should_not_email(@u_watcher)
|
|
should_not_email(@u_participant_mentioned)
|
|
should_not_email(@subscriber)
|
|
should_not_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(subscriber_to_label)
|
|
should_email(subscriber_to_label2)
|
|
end
|
|
end
|
|
|
|
describe :close_issue do
|
|
it 'should sent email to issue assignee and issue author' do
|
|
notification.close_issue(issue, @u_disabled)
|
|
|
|
should_email(issue.assignee)
|
|
should_email(issue.author)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
|
|
describe :reopen_issue do
|
|
it 'should send email to issue assignee and issue author' do
|
|
notification.reopen_issue(issue, @u_disabled)
|
|
|
|
should_email(issue.assignee)
|
|
should_email(issue.author)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Merge Requests' do
|
|
let(:project) { create(:project, :public) }
|
|
let(:merge_request) { create :merge_request, source_project: project, assignee: create(:user), description: 'cc @participant' }
|
|
|
|
before do
|
|
build_team(merge_request.target_project)
|
|
add_users_with_subscription(merge_request.target_project, merge_request)
|
|
ActionMailer::Base.deliveries.clear
|
|
end
|
|
|
|
describe :new_merge_request do
|
|
it do
|
|
notification.new_merge_request(merge_request, @u_disabled)
|
|
|
|
should_email(merge_request.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@watcher_and_subscriber)
|
|
should_email(@u_participant_mentioned)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
|
|
it "emails subscribers of the merge request's labels" do
|
|
subscriber = create(:user)
|
|
label = create(:label, merge_requests: [merge_request])
|
|
label.toggle_subscription(subscriber)
|
|
notification.new_merge_request(merge_request, @u_disabled)
|
|
|
|
should_email(subscriber)
|
|
end
|
|
end
|
|
|
|
describe :reassigned_merge_request do
|
|
it do
|
|
notification.reassigned_merge_request(merge_request, merge_request.author)
|
|
|
|
should_email(merge_request.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
|
|
describe :relabel_merge_request do
|
|
let(:label) { create(:label, merge_requests: [merge_request]) }
|
|
let(:label2) { create(:label) }
|
|
let!(:subscriber_to_label) { create(:user).tap { |u| label.toggle_subscription(u) } }
|
|
let!(:subscriber_to_label2) { create(:user).tap { |u| label2.toggle_subscription(u) } }
|
|
|
|
it "emails subscribers of the merge request's added labels only" do
|
|
notification.relabeled_merge_request(merge_request, [label2], @u_disabled)
|
|
|
|
should_not_email(subscriber_to_label)
|
|
should_email(subscriber_to_label2)
|
|
end
|
|
|
|
it "doesn't send email to anyone but subscribers of the given labels" do
|
|
notification.relabeled_merge_request(merge_request, [label2], @u_disabled)
|
|
|
|
should_not_email(merge_request.assignee)
|
|
should_not_email(merge_request.author)
|
|
should_not_email(@u_watcher)
|
|
should_not_email(@u_participant_mentioned)
|
|
should_not_email(@subscriber)
|
|
should_not_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(subscriber_to_label)
|
|
should_email(subscriber_to_label2)
|
|
end
|
|
end
|
|
|
|
describe :closed_merge_request do
|
|
it do
|
|
notification.close_mr(merge_request, @u_disabled)
|
|
|
|
should_email(merge_request.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
|
|
describe :merged_merge_request do
|
|
it do
|
|
notification.merge_mr(merge_request, @u_disabled)
|
|
|
|
should_email(merge_request.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
|
|
describe :reopen_merge_request do
|
|
it do
|
|
notification.reopen_mr(merge_request, @u_disabled)
|
|
|
|
should_email(merge_request.assignee)
|
|
should_email(@u_watcher)
|
|
should_email(@u_participant_mentioned)
|
|
should_email(@subscriber)
|
|
should_email(@watcher_and_subscriber)
|
|
should_not_email(@unsubscriber)
|
|
should_not_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Projects' do
|
|
let(:project) { create :project }
|
|
|
|
before do
|
|
build_team(project)
|
|
ActionMailer::Base.deliveries.clear
|
|
end
|
|
|
|
describe :project_was_moved do
|
|
it do
|
|
notification.project_was_moved(project, "gitlab/gitlab")
|
|
|
|
should_email(@u_watcher)
|
|
should_email(@u_participating)
|
|
should_not_email(@u_disabled)
|
|
end
|
|
end
|
|
end
|
|
|
|
def build_team(project)
|
|
@u_watcher = create(:user, notification_level: Notification::N_WATCH)
|
|
@u_participating = create(:user, notification_level: Notification::N_PARTICIPATING)
|
|
@u_participant_mentioned = create(:user, username: 'participant', notification_level: Notification::N_PARTICIPATING)
|
|
@u_disabled = create(:user, notification_level: Notification::N_DISABLED)
|
|
@u_mentioned = create(:user, username: 'mention', notification_level: Notification::N_MENTION)
|
|
@u_committer = create(:user, username: 'committer')
|
|
@u_not_mentioned = create(:user, username: 'regular', notification_level: Notification::N_PARTICIPATING)
|
|
@u_outsider_mentioned = create(:user, username: 'outsider')
|
|
|
|
project.team << [@u_watcher, :master]
|
|
project.team << [@u_participating, :master]
|
|
project.team << [@u_participant_mentioned, :master]
|
|
project.team << [@u_disabled, :master]
|
|
project.team << [@u_mentioned, :master]
|
|
project.team << [@u_committer, :master]
|
|
project.team << [@u_not_mentioned, :master]
|
|
end
|
|
|
|
def add_users_with_subscription(project, issuable)
|
|
@subscriber = create :user
|
|
@unsubscriber = create :user
|
|
@subscribed_participant = create(:user, username: 'subscribed_participant', notification_level: Notification::N_PARTICIPATING)
|
|
@watcher_and_subscriber = create(:user, notification_level: Notification::N_WATCH)
|
|
|
|
project.team << [@subscribed_participant, :master]
|
|
project.team << [@subscriber, :master]
|
|
project.team << [@unsubscriber, :master]
|
|
project.team << [@watcher_and_subscriber, :master]
|
|
|
|
issuable.subscriptions.create(user: @subscriber, subscribed: true)
|
|
issuable.subscriptions.create(user: @subscribed_participant, subscribed: true)
|
|
issuable.subscriptions.create(user: @unsubscriber, subscribed: false)
|
|
# Make the watcher a subscriber to detect dupes
|
|
issuable.subscriptions.create(user: @watcher_and_subscriber, subscribed: true)
|
|
end
|
|
end
|