35b9274f12
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/59777. In earlier iterations of our implementation of Git object deduplication we thought we would be making extensive use of Git remotes in pool repositories in the future, and that we should manage these remotes carefully from the start. We now expect we only care about one remote, namely the source project. The other remotes are there only for forensic purposes. Before this MR we tried to also remove pool remotes when member projects got deleted, with the UnlinkRepositoryFromObjectPool RPC. This is fragile when there are race conditions (see https://gitlab.com/gitlab-org/gitaly/issues/1568#note_153955926). We have spent some time making this RPC less fragile in https://gitlab.com/gitlab-org/gitaly/merge_requests/1151 but looking at this problem again, I think we should just stop calling it.
47 lines
1.3 KiB
Ruby
47 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe PoolRepository do
|
|
describe 'associations' do
|
|
it { is_expected.to belong_to(:shard) }
|
|
it { is_expected.to have_one(:source_project) }
|
|
it { is_expected.to have_many(:member_projects) }
|
|
end
|
|
|
|
describe 'validations' do
|
|
let!(:pool_repository) { create(:pool_repository) }
|
|
|
|
it { is_expected.to validate_presence_of(:shard) }
|
|
it { is_expected.to validate_presence_of(:source_project) }
|
|
end
|
|
|
|
describe '#disk_path' do
|
|
it 'sets the hashed disk_path' do
|
|
pool = create(:pool_repository)
|
|
|
|
expect(pool.disk_path).to match(%r{\A@pools/\h{2}/\h{2}/\h{64}})
|
|
end
|
|
end
|
|
|
|
describe '#mark_obsolete_if_last' do
|
|
let(:pool) { create(:pool_repository, :ready) }
|
|
|
|
context 'when the last member leaves' do
|
|
it 'schedules pool removal' do
|
|
expect(::ObjectPool::DestroyWorker).to receive(:perform_async).with(pool.id).and_call_original
|
|
|
|
pool.mark_obsolete_if_last(pool.source_project.repository)
|
|
end
|
|
end
|
|
|
|
context 'when the second member leaves' do
|
|
it 'does not schedule pool removal' do
|
|
create(:project, :repository, pool_repository: pool)
|
|
expect(::ObjectPool::DestroyWorker).not_to receive(:perform_async).with(pool.id)
|
|
|
|
pool.mark_obsolete_if_last(pool.source_project.repository)
|
|
end
|
|
end
|
|
end
|
|
end
|