gitlab-org--gitlab-foss/app/services/merge_requests
Rydkin Maxim 14326c88f7 refactor merge request build service
add changelog entry

replace local variables `merge_request` with instance ones

modify `MergeRequests::BuildService` to fix failed tests

extract `assign_target_project` method

remove unnecessary instance variables

remove exclamation marks and rewrite conditionals to improve readability

extract `params_does_not_contain_branches?` method, rename `unprepared_merge_request` method to `uncreatable_merge_request`

replace instance variables `merge_request` and `error_messages` with getters and setters; divide `set_title_and_description` method on two separate ones

refactor `execute` method

return `set_title_and_description` method

rename `branches_selected?` method to `branches_present?` to make it more different from `branches_specified?`

fixes after discussion

renamed method branches_valid?

fix space

return assigning methods into `execute` method

simplify `find_target_branch` and `find_source_project` methods

fix spec `merge request issuable record that supports slash commands in its description and notes`
2017-01-31 10:06:00 +03:00
..
add_todo_when_build_fails_service.rb
assign_issues_service.rb
base_service.rb Backport EE changes on approvals reset for closed MRs 2017-01-23 12:45:53 -02:00
build_service.rb refactor merge request build service 2017-01-31 10:06:00 +03:00
close_service.rb
create_service.rb
get_urls_service.rb
merge_request_diff_cache_service.rb
merge_service.rb
merge_when_pipeline_succeeds_service.rb
post_merge_service.rb
refresh_service.rb Backport EE changes on approvals reset for closed MRs 2017-01-23 12:45:53 -02:00
reopen_service.rb
resolve_service.rb
resolved_discussion_notification_service.rb
update_service.rb support /merge slash comand for MRs 2017-01-11 08:48:07 -05:00