kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/models
History
Yorick Peterse 19428e8008
Preload pipeline data for project pipelines 
When displaying the pipelines of a project we now preload the following
data:

1. Authors of the commits that belong to these pipelines
2. The number of warnings per pipeline, which is used by
   Ci::Pipeline#has_warnings?

== Commit Authors

Previously this data was queried for every Commit separately, leading to
20 SQL queries being executed in the worst case. With an average of 3 to
5 milliseconds per SQL query this could result in 100 milliseconds being
spent in _just_ getting Commit authors.

To preload this data Commit#author now uses BatchLoader (through
Commit#lazy_author), and a separate module
Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded
before they are used.

== Number of warnings

This changes Ci::Pipeline#has_warnings? so it supports preloading of the
number of warnings per pipeline. This removes the need for executing a
COUNT(*) query for every pipeline just to see if it has any warnings or
not.
2018-05-17 13:53:00 +02:00
..
application_setting Store application wide terms 2018-05-04 13:52:55 +02:00
badges Projects and groups badges API 2018-03-05 17:51:40 +00:00
blob_viewer Bump Gitaly to 0.98.0 2018-05-07 14:10:04 +02:00
ci Preload pipeline data for project pipelines 2018-05-17 13:53:00 +02:00
clusters Backport CE changes from gitlab-ee#518a29073a9 2018-05-10 11:04:25 +02:00
concerns only issue a warning if column doesn't exist 2018-05-10 10:00:32 -05:00
conversational_development_index Store & use ConvDev percentages returned by Version app 2017-08-07 20:52:08 +02:00
cycle_analytics Adapt cycle analytics spec helper and cycle analytics usage data spec 2018-03-01 16:43:26 +00:00
diff_viewer Batchload blobs for diff generation 2017-11-21 13:53:26 +01:00
hooks Merge branch 'feature/merge-request-system-hook' into 'master' 2018-01-18 11:37:16 +00:00
issue Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
members Ensure member notifications are sent after the member actual creation/update in the DB 2018-04-26 08:28:05 +02:00
merge_request Cache merged and closed events data in merge_request_metrics table 2018-01-02 17:45:25 -02:00
network
project_services Bump Gitaly to 0.98.0 2018-05-07 14:10:04 +02:00
protected_branch
ability_spec.rb Remove edit_note and update_note abilities in favor of admin_note 2018-04-10 15:46:20 +02:00
abuse_report_spec.rb Optimize a few simple spec files by using set 2017-09-13 13:35:18 +02:00
active_session_spec.rb Display and revoke active sessions 2018-05-02 08:08:16 +00:00
appearance_spec.rb Delete remote uploads 2018-05-16 08:58:07 +02:00
application_setting_spec.rb Store application wide terms 2018-05-04 13:52:55 +02:00
award_emoji_spec.rb
badge_spec.rb Projects and groups badges API 2018-03-05 17:51:40 +00:00
blob_spec.rb Batchload blobs for diff generation 2017-11-21 13:53:26 +01:00
board_spec.rb
broadcast_message_spec.rb Backport: Propagate broadcast messages to secondaries 2018-04-11 11:28:44 -07:00
chat_name_spec.rb Expose ChatName objects to slash commands 2018-02-23 14:37:53 +01:00
chat_team_spec.rb Optimize a few simple spec files by using set 2017-09-13 13:35:18 +02:00
commit_collection_spec.rb Optimise getting the pipeline status of commits 2017-11-16 16:01:14 +01:00
commit_range_spec.rb Only search for MR revert commits on notes after MR was merged 2018-01-12 13:19:05 +00:00
commit_spec.rb Preload pipeline data for project pipelines 2018-05-17 13:53:00 +02:00
commit_status_spec.rb Ensure that enqueuing a commit status always sets 'queued_at' value 2018-04-10 15:13:55 +02:00
compare_spec.rb Remove unused Compare#base_commit 2018-03-08 11:39:50 -03:00
container_repository_spec.rb Prevent new / renamed project from using a repository path that already exists on disk 2017-08-25 20:06:06 +02:00
cycle_analytics_spec.rb Adapt cycle analytics spec helper and cycle analytics usage data spec 2018-03-01 16:43:26 +00:00
deploy_key_spec.rb Fall back on ghost user when deploy key user is not set 2018-03-28 18:54:15 +02:00
deploy_keys_project_spec.rb Merge branch 'sh-migrate-can-push-to-deploy-keys-projects-10-3' into 'security-10-3' 2018-01-16 17:04:51 -08:00
deploy_token_spec.rb Refactor deploy token methods on Ci::Build 2018-04-20 12:18:41 -05:00
deployment_spec.rb Atomic internal ids for all models 2018-04-20 14:00:15 +00:00
diff_discussion_spec.rb Fix links to old commits in merge requests 2017-12-29 14:44:39 +01:00
diff_note_spec.rb Use persisted diff data instead fetching Git on discussions 2018-04-30 20:07:21 -03:00
discussion_spec.rb
email_spec.rb remove extra whitespace 2017-10-27 17:35:40 +02:00
environment_spec.rb Allow admins to push to empty repos 2018-04-24 14:06:59 +02:00
event_collection_spec.rb Use a specialized class for querying events 2017-08-10 17:45:49 +02:00
event_spec.rb Singularize model name. 2018-03-06 12:53:14 +01:00
external_issue_spec.rb
fork_network_member_spec.rb Delete the fork network when removing the last membership 2017-11-17 12:58:15 +01:00
fork_network_spec.rb Unlink a project from a fork network when it's source was deleted. 2017-11-03 12:17:59 +01:00
forked_project_link_spec.rb Add a project forks spec helper 2017-10-07 11:46:23 +02:00
generic_commit_status_spec.rb Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
global_milestone_spec.rb Move total time spend calculation to milestoneish 2017-11-11 16:47:39 +02:00
gpg_key_spec.rb Invalidate GpgSignatures associated to GpgKeySubkeys when revoking the GpgKey 2017-10-05 08:26:02 -05:00
gpg_key_subkey_spec.rb Add some basic specs and refactor model and validations 2017-10-05 08:25:27 -05:00
gpg_signature_spec.rb Fix error with GPG signature updater when commit was deleted 2017-10-07 10:47:53 -05:00
group_custom_attribute_spec.rb Support custom attributes on groups 2017-11-06 10:51:50 +01:00
group_label_spec.rb Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
group_milestone_spec.rb Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
group_spec.rb Delete remote uploads 2018-05-16 08:58:07 +02:00
guest_spec.rb Add a unique and not null constraint on the project_features.project_id column 2018-05-15 14:20:14 +02:00
identity_spec.rb Fixed user synced attributes metadata after removing current provider 2018-02-15 09:27:38 +00:00
instance_configuration_spec.rb Added ssh fingerprint, gitlab ci and pages information in an instance configuration page 2017-10-25 23:51:26 +03:00
internal_id_spec.rb Double-check next value for internal ids. 2018-04-16 13:59:20 +02:00
issue_collection_spec.rb Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
issue_spec.rb Shows new branch/mr button even when branch exists 2018-04-19 13:56:36 +02:00
key_spec.rb Validate SSH keys through the sshkey gem 2018-02-16 11:32:08 -05:00
label_link_spec.rb
label_priority_spec.rb
label_spec.rb
legacy_diff_discussion_spec.rb
lfs_file_lock_spec.rb Backport of LFS File Locking API 2018-02-07 09:04:00 -05:00
lfs_object_spec.rb Fix file_store for artifacts and lfs when saving 2018-05-01 22:27:54 +02:00
lfs_objects_project_spec.rb Fix syntax error in LFS objects specs 2017-09-13 13:35:18 +02:00
list_spec.rb
member_spec.rb Use the DatabaseCleaner 'deletion' strategy instead of 'truncation' 2018-01-24 17:25:55 +00:00
merge_request_diff_commit_spec.rb [Rails5] Update type_cast_*_database methods 2018-04-06 10:57:19 +00:00
merge_request_diff_file_spec.rb
merge_request_diff_spec.rb Display related merge requests in commit detail page 2018-01-12 20:38:36 +00:00
merge_request_spec.rb Display merge commit SHA in merge widget after merge 2018-05-07 14:09:47 -03:00
milestone_spec.rb Atomic internal ids for all models 2018-04-20 14:00:15 +00:00
namespace_spec.rb Backport of 4084-epics-username-autocomplete 2018-05-04 11:33:09 -06:00
note_spec.rb Fix N+1 queries when loading participants for a commit note 2018-04-18 22:04:22 -07:00
notification_recipient_spec.rb Port read_cross_project ability from EE 2018-02-22 17:11:36 +01:00
notification_setting_spec.rb [Rails5] Fix spec/models/notification_setting_spec.rb 2018-05-01 18:30:37 +11:00
pages_domain_spec.rb Add HTTPS-only pages 2018-03-22 19:58:36 +01:00
personal_access_token_spec.rb Fix new personal access token showing up in a flash message 2017-12-07 16:22:37 -06:00
project_authorization_spec.rb Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
project_auto_devops_spec.rb DRY project-level predefined variables 2018-03-13 14:00:14 +01:00
project_ci_cd_setting_spec.rb Introduce new ProjectCiCdSetting 2018-04-16 14:05:35 +02:00
project_custom_attribute_spec.rb Support custom attributes on projects 2017-11-06 10:51:46 +01:00
project_deploy_token_spec.rb Addresses database comments 2018-04-06 21:20:17 -05:00
project_feature_spec.rb Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
project_group_link_spec.rb Use the DatabaseCleaner 'deletion' strategy instead of 'truncation' 2018-01-24 17:25:55 +00:00
project_import_state_spec.rb Backports every CE related change from ee-44542 to CE 2018-05-04 17:33:26 +02:00
project_label_spec.rb Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
project_snippet_spec.rb
project_spec.rb Delete remote uploads 2018-05-16 08:58:07 +02:00
project_statistics_spec.rb Update ProjectStatistics#build_artifacts_size synchronously without summing (#41059) 2018-04-19 18:35:40 +10:00
project_team_spec.rb Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
project_wiki_spec.rb Fix finding wiki pages when they have invalidly-encoded content 2018-05-09 18:03:03 +02:00
protectable_dropdown_spec.rb Whitelist or fix additional Gitlab/PublicSend cop violations 2017-08-14 12:14:11 -04:00
protected_branch_spec.rb Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
protected_tag_spec.rb
push_event_payload_spec.rb Migrate events into a new format 2017-08-10 17:45:44 +02:00
push_event_spec.rb Last push widget will show banner for new pushes to previously merged branch 2018-01-15 16:45:56 -06:00
redirect_route_spec.rb Fix conflicting redirect search 2017-08-08 10:30:07 -07:00
release_spec.rb
remote_mirror_spec.rb Adds remote mirror table migration 2018-05-07 12:00:13 +02:00
repository_spec.rb Move Gitlab::Git::Repository#add_branch to mandatory 2018-05-14 12:18:23 +02:00
route_spec.rb Remove permanent redirects 2018-03-28 14:12:08 +02:00
sent_notification_spec.rb Don't show an "Unsubscribe" link in snippet comment notifications 2017-10-09 15:03:05 +02:00
service_spec.rb Merge branch 'jej/mattermost-notification-confidentiality-10-6' into 'security-10-6' 2018-04-05 08:41:56 +02:00
snippet_blob_spec.rb
snippet_spec.rb Use fuzzy search with minimum length of 3 characters where appropriate 2017-11-27 11:29:40 +01:00
spam_log_spec.rb
subscription_spec.rb
system_note_metadata_spec.rb
term_agreement_spec.rb Add model to track users accepting agreements 2018-05-04 13:52:55 +02:00
timelog_spec.rb
todo_spec.rb Set todos#author_id to NOT NULL. 2018-02-05 16:16:57 +01:00
tree_spec.rb
trending_project_spec.rb Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
upload_spec.rb Revert "Merge branch '3867-port-to-ce' into 'master'" 2018-02-28 21:09:34 +01:00
user_agent_detail_spec.rb
user_callout_spec.rb Change UserCallout feautre_name to enum 2018-02-03 00:18:25 +01:00
user_custom_attribute_spec.rb Support custom attributes on users 2017-09-28 16:49:42 +00:00
user_interacted_project_spec.rb Operate on ids to avoid unnecessary loading. 2018-03-06 12:53:15 +01:00
user_spec.rb Resolve "Opening Project with invite but without accepting leads to 404 error page" 2018-05-17 09:19:47 +00:00
wiki_directory_spec.rb
wiki_page_spec.rb Bump Gitaly to 0.98.0 2018-05-07 14:10:04 +02:00