37b17fa61a
Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
24 lines
447 B
Ruby
24 lines
447 B
Ruby
# frozen_string_literal: true
|
|
|
|
module ToggleAwardEmoji
|
|
extend ActiveSupport::Concern
|
|
|
|
def toggle_award_emoji
|
|
authenticate_user!
|
|
name = params.require(:name)
|
|
|
|
service = AwardEmojis::ToggleService.new(awardable, name, current_user).execute
|
|
|
|
if service[:status] == :success
|
|
render json: { ok: true }
|
|
else
|
|
render json: { ok: false }
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def awardable
|
|
raise NotImplementedError
|
|
end
|
|
end
|