kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/doc/development
History
Douwe Maan 7f47dddc25 Merge branch 'patch-1' into 'master' 
Clarify blank line rule in newlines_styleguide.md

## What does this MR do?

* Corrects a typo in the GitLab Ruby newlines style guide
* Makes some vague language in the original guideline more precise

## Are there points in the code the reviewer needs to double check?

n/a

## Why was this MR needed?

* There was a typo in the original text.
* The original text was vague.

## What are the relevant issue numbers?

n/a

## Screenshots (if relevant)

n/a

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added  (Is this recommended for this kind of patch?)
- ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~API support added~~
- Tests
  - ~~Added for this feature/bug~~
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !6048
2016-08-30 17:43:56 +00:00
..
adding_database_indexes.md Added documentation on adding database indexes 2016-08-11 14:22:50 +02:00
architecture.md Add "GitLab team members only" to diagram link 2016-06-28 03:12:26 +00:00
ci_setup.md Fix dead links in the docs 2016-06-26 12:43:10 +09:00
code_review.md Re-add a note about sarcasm to the Code Review guide 2016-04-10 22:54:44 -04:00
db_dump.md Fix typos in all docs [skip ci] 2015-11-24 02:19:17 +03:00
doc_styleguide.md Merge branch 'doc/styleguide-fix-grep' into 'master' 2016-08-29 20:13:49 +00:00
gitlab_architecture_diagram.png optimize png images losslessly using zopflipng 2016-06-29 19:22:15 +08:00
gitlab_diagram_overview.odg
gotchas.md Remove CHANGELOG and fix typo 2016-08-04 12:30:27 +02:00
instrumentation.md Track method call times/counts as a single metric 2016-06-17 13:09:55 -04:00
licensing.md Add relevant commands to the licensing document, resolve some feedback. 2016-06-06 13:39:36 -06:00
migration_style_guide.md Added checks for migration downtime 2016-07-20 12:41:56 +02:00
newlines_styleguide.md Clarify blank line rule in newlines_styleguide.md 2016-08-26 06:12:30 +00:00
omnibus.md Document fun facts about omnibus-gitlab 2015-02-19 11:20:58 +01:00
performance.md Corrected links/usernames in performance guide 2016-08-11 14:31:19 +02:00
profiling.md Updated profiling guides for Sherlock 2015-11-09 14:29:10 +01:00
rake_tasks.md Add 'run tests' docs from GDK 2016-08-05 17:19:37 +02:00
README.md Added documentation on adding database indexes 2016-08-11 14:22:50 +02:00
scss_styleguide.md SCSS Style Guide fixes. 2016-03-23 14:39:12 -06:00
shared_files.md Clarify puppies 2015-10-26 14:28:31 +01:00
shell_commands.md Update Shell Commands doc for configurable git binary path 2015-11-03 17:10:17 -05:00
sidekiq_debugging.md
sql.md Added basic SQL guidelines 2016-03-08 11:28:50 +01:00
testing.md Enable RSpec/NotToNot cop and auto-correct offenses 2016-05-24 15:40:29 -04:00
ui_guide.md Add reference to product map. 2016-08-11 10:11:17 +00:00
what_requires_downtime.md Mention add_column_with_default in downtime guide 2016-08-10 11:09:53 +02:00

README.md

Development

Outside of docs

Styleguides

Process

Backend howtos

Databases

Compliance