kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/controllers
History
Rémy Coutable 45ce5ff7ea
Fix Projects::MergeRequests::DiffsController specs 
These specs were flaky and only passing after a retry due to how
rspec-retry works.

1. The test with paths that don't exist was returning 200 on the first
  try, then 404 on the second, not because the paths don't exist, but
  because the MR IID didn't change, thus the MR couldn't be found.
  I decided to remove the test entirely since we don't seem to return
  404 for paths that don't exist.
2. The test with a user that cannot view the merge request was failing
  the first time because the project owner wasn't removed with
  `project.team.truncate`.
  Changing the `let(:user)` to `create(:user)` and calling
  `project.add_maintainer(user)` in the `before` block fix the test.

Signed-off-by: Rémy Coutable <remy@rymai.me>
 		2019-02-18 12:13:08 +01:00
..
admin Admin section finds users case-insensitively 2019-02-12 14:28:06 -08:00
boards Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
concerns Fix Content-Disposition hard-coded to attachments 2019-02-13 11:09:52 -08:00
dashboard Exclude public group milestones from counts 2019-02-14 14:49:18 +08:00
explore Update specs to rails5 format 2018-12-19 10:04:31 +11:00
google_api Update specs to rails5 format 2018-12-19 10:04:31 +11:00
groups Remove TLD validation from Cluster#domain 2019-02-14 16:25:41 -06:00
import Improve the GitHub and Gitea import feature table interface 2019-02-13 00:15:57 +00:00
instance_statistics Resolve "Remove usage ping payload from Cohorts, add to Settings" 2018-09-06 12:43:14 +00:00
ldap Update specs to rails5 format 2018-12-19 10:04:31 +11:00
oauth Update specs to rails5 format 2018-12-19 10:04:31 +11:00
profiles Add setting for first day of the week 2019-02-06 17:33:56 +01:00
projects Fix Projects::MergeRequests::DiffsController specs 2019-02-18 12:13:08 +01:00
snippets Update specs to rails5 format 2018-12-19 10:04:31 +11:00
users Update specs to rails5 format 2018-12-19 10:04:31 +11:00
abuse_reports_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
application_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
autocomplete_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
dashboard_controller_spec.rb Merge branch 'security-fix-pat-web-access' into 'master' 2018-11-28 19:13:59 -05:00
graphql_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
groups_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
health_check_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
health_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
help_controller_spec.rb Fix broken links on help page 2019-02-11 23:41:58 +01:00
invites_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
metrics_controller_spec.rb Remove healthchecks from prometheus endpoint 2018-07-12 17:37:51 +00:00
notification_settings_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
omniauth_callbacks_controller_spec.rb Avoid CSRF check on SAML failure endpoint 2019-02-04 10:10:51 +00:00
passwords_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
profiles_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
projects_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
registrations_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
root_controller_spec.rb Fix tests 2018-11-13 15:27:42 +08:00
search_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
sent_notifications_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
sessions_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
snippets_controller_spec.rb Fix deprecation: Using positional arguments in integration tests 2019-01-02 22:33:28 +01:00
uploads_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
user_callouts_controller_spec.rb Update specs to rails5 format 2018-12-19 10:04:31 +11:00
users_controller_spec.rb Fix contributed projects finder shown private info 2019-01-31 16:51:16 +01:00