![]() There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893 |
||
---|---|---|
.. | ||
admin | ||
ci | ||
groups | ||
import | ||
oauth | ||
profiles | ||
projects | ||
abuse_reports_controller_spec.rb | ||
application_controller_spec.rb | ||
autocomplete_controller_spec.rb | ||
blob_controller_spec.rb | ||
groups_controller_spec.rb | ||
health_check_controller_spec.rb | ||
help_controller_spec.rb | ||
invites_controller_spec.rb | ||
namespaces_controller_spec.rb | ||
notification_settings_controller_spec.rb | ||
projects_controller_spec.rb | ||
registrations_controller_spec.rb | ||
root_controller_spec.rb | ||
sent_notifications_controller_spec.rb | ||
sessions_controller_spec.rb | ||
snippets_controller_spec.rb | ||
uploads_controller_spec.rb | ||
users_controller_spec.rb |