37b17fa61a
Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
94 lines
2.6 KiB
Ruby
94 lines
2.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Awardable do
|
|
let!(:issue) { create(:issue) }
|
|
let!(:award_emoji) { create(:award_emoji, :downvote, awardable: issue) }
|
|
|
|
describe "Associations" do
|
|
subject { build(:issue) }
|
|
|
|
it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
|
|
end
|
|
|
|
describe "ClassMethods" do
|
|
let!(:issue2) { create(:issue) }
|
|
let!(:award_emoji2) { create(:award_emoji, awardable: issue2) }
|
|
|
|
describe "orders" do
|
|
it "orders on upvotes" do
|
|
expect(Issue.order_upvotes_desc.to_a).to eq [issue2, issue]
|
|
end
|
|
|
|
it "orders on downvotes" do
|
|
expect(Issue.order_downvotes_desc.to_a).to eq [issue, issue2]
|
|
end
|
|
end
|
|
|
|
describe "#awarded" do
|
|
it "filters by user and emoji name" do
|
|
expect(Issue.awarded(award_emoji.user, "thumbsup")).to be_empty
|
|
expect(Issue.awarded(award_emoji.user, "thumbsdown")).to eq [issue]
|
|
expect(Issue.awarded(award_emoji2.user, "thumbsup")).to eq [issue2]
|
|
expect(Issue.awarded(award_emoji2.user, "thumbsdown")).to be_empty
|
|
end
|
|
|
|
it "filters by user and any emoji" do
|
|
issue3 = create(:issue)
|
|
create(:award_emoji, awardable: issue3, name: "star", user: award_emoji.user)
|
|
create(:award_emoji, awardable: issue3, name: "star", user: award_emoji2.user)
|
|
|
|
expect(Issue.awarded(award_emoji.user)).to contain_exactly(issue, issue3)
|
|
expect(Issue.awarded(award_emoji2.user)).to contain_exactly(issue2, issue3)
|
|
end
|
|
end
|
|
|
|
describe "#not_awarded" do
|
|
it "returns issues not awarded by user" do
|
|
expect(Issue.not_awarded(award_emoji.user)).to eq [issue2]
|
|
expect(Issue.not_awarded(award_emoji2.user)).to eq [issue]
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#upvotes" do
|
|
it "counts the number of upvotes" do
|
|
expect(issue.upvotes).to be 0
|
|
end
|
|
end
|
|
|
|
describe "#downvotes" do
|
|
it "counts the number of downvotes" do
|
|
expect(issue.downvotes).to be 1
|
|
end
|
|
end
|
|
|
|
describe '#user_can_award?' do
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
issue.project.add_guest(user)
|
|
end
|
|
|
|
it 'is truthy when the user is allowed to award emoji' do
|
|
expect(issue.user_can_award?(user)).to be_truthy
|
|
end
|
|
|
|
it 'is falsy when the project is archived' do
|
|
issue.project.update!(archived: true)
|
|
|
|
expect(issue.user_can_award?(user)).to be_falsy
|
|
end
|
|
end
|
|
|
|
describe 'querying award_emoji on an Awardable' do
|
|
let(:issue) { create(:issue) }
|
|
|
|
it 'sorts in ascending fashion' do
|
|
create_list(:award_emoji, 3, awardable: issue)
|
|
|
|
expect(issue.award_emoji).to eq issue.award_emoji.sort_by(&:id)
|
|
end
|
|
end
|
|
end
|