6606a45030
There are two problems in the current implementation: 1. If a project is marked for deletion via the `pending_delete` flag and then the namespace was quickly deleted, it's possible that the namespace skips over that project and leaves that project in an orphaned state. 2. Before namespace deletion, the namespace attempts to clean up all the relevant storage paths. However, if all projects have been removed synchronously, then the namespace will not be able to clean anything. To prevent this, we should load the paths to be deleted before actually destroying projects. The specs were missing this second case due to a permission issue that caused project removal never to happen.
27 lines
904 B
Ruby
27 lines
904 B
Ruby
module Groups
|
|
class DestroyService < Groups::BaseService
|
|
def async_execute
|
|
# Soft delete via paranoia gem
|
|
group.destroy
|
|
job_id = GroupDestroyWorker.perform_async(group.id, current_user.id)
|
|
Rails.logger.info("User #{current_user.id} scheduled a deletion of group ID #{group.id} with job ID #{job_id}")
|
|
end
|
|
|
|
def execute
|
|
group.prepare_for_destroy
|
|
|
|
group.projects.with_deleted.each do |project|
|
|
# Execute the destruction of the models immediately to ensure atomic cleanup.
|
|
# Skip repository removal because we remove directory with namespace
|
|
# that contain all these repositories
|
|
::Projects::DestroyService.new(project, current_user, skip_repo: true).execute
|
|
end
|
|
|
|
group.children.each do |group|
|
|
DestroyService.new(group, current_user).async_execute
|
|
end
|
|
|
|
group.really_destroy!
|
|
end
|
|
end
|
|
end
|