4f4de36cac
This change is a fairly straightforward refactor to extract the tracing and correlation-id code from the gitlab rails codebase into the new LabKit-Ruby project. The corresponding import into LabKit-Ruby was in https://gitlab.com/gitlab-org/labkit-ruby/merge_requests/1 The code itself remains very similar for now. Extracting it allows us to reuse it in other projects, such as Gitaly-Ruby. This will give us the advantages of correlation-ids and distributed tracing in that project too.
93 lines
2.7 KiB
Ruby
93 lines
2.7 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::Sentry do
|
|
describe '.context' do
|
|
it 'adds the locale to the tags' do
|
|
expect(described_class).to receive(:enabled?).and_return(true)
|
|
|
|
described_class.context(nil)
|
|
|
|
expect(Raven.tags_context[:locale].to_s).to eq(I18n.locale.to_s)
|
|
end
|
|
end
|
|
|
|
describe '.track_exception' do
|
|
let(:exception) { RuntimeError.new('boom') }
|
|
|
|
before do
|
|
allow(described_class).to receive(:enabled?).and_return(true)
|
|
end
|
|
|
|
it 'raises the exception if it should' do
|
|
expect(described_class).to receive(:should_raise_for_dev?).and_return(true)
|
|
expect { described_class.track_exception(exception) }
|
|
.to raise_error(RuntimeError)
|
|
end
|
|
|
|
context 'when exceptions should not be raised' do
|
|
before do
|
|
allow(described_class).to receive(:should_raise_for_dev?).and_return(false)
|
|
allow(Labkit::Correlation::CorrelationId).to receive(:current_id).and_return('cid')
|
|
end
|
|
|
|
it 'logs the exception with all attributes passed' do
|
|
expected_extras = {
|
|
some_other_info: 'info',
|
|
issue_url: 'http://gitlab.com/gitlab-org/gitlab-ce/issues/1'
|
|
}
|
|
|
|
expected_tags = {
|
|
correlation_id: 'cid'
|
|
}
|
|
|
|
expect(Raven).to receive(:capture_exception)
|
|
.with(exception,
|
|
tags: a_hash_including(expected_tags),
|
|
extra: a_hash_including(expected_extras))
|
|
|
|
described_class.track_exception(
|
|
exception,
|
|
issue_url: 'http://gitlab.com/gitlab-org/gitlab-ce/issues/1',
|
|
extra: { some_other_info: 'info' }
|
|
)
|
|
end
|
|
|
|
it 'sets the context' do
|
|
expect(described_class).to receive(:context)
|
|
|
|
described_class.track_exception(exception)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '.track_acceptable_exception' do
|
|
let(:exception) { RuntimeError.new('boom') }
|
|
|
|
before do
|
|
allow(described_class).to receive(:enabled?).and_return(true)
|
|
allow(Labkit::Correlation::CorrelationId).to receive(:current_id).and_return('cid')
|
|
end
|
|
|
|
it 'calls Raven.capture_exception' do
|
|
expected_extras = {
|
|
some_other_info: 'info',
|
|
issue_url: 'http://gitlab.com/gitlab-org/gitlab-ce/issues/1'
|
|
}
|
|
|
|
expected_tags = {
|
|
correlation_id: 'cid'
|
|
}
|
|
|
|
expect(Raven).to receive(:capture_exception)
|
|
.with(exception,
|
|
tags: a_hash_including(expected_tags),
|
|
extra: a_hash_including(expected_extras))
|
|
|
|
described_class.track_acceptable_exception(
|
|
exception,
|
|
issue_url: 'http://gitlab.com/gitlab-org/gitlab-ce/issues/1',
|
|
extra: { some_other_info: 'info' }
|
|
)
|
|
end
|
|
end
|
|
end
|