gitlab-org--gitlab-foss/spec/controllers/projects/cycle_analytics_controller_spec.rb
Vitali Tatarintev 6a6411938a Change be_success to be_successful in specs
Fixes deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
2019-08-19 14:40:56 +02:00

63 lines
1.5 KiB
Ruby

# frozen_string_literal: true
require 'spec_helper'
describe Projects::CycleAnalyticsController do
let(:project) { create(:project, :repository) }
let(:user) { create(:user) }
before do
sign_in(user)
project.add_maintainer(user)
end
context "counting page views for 'show'" do
it 'increases the counter' do
expect(Gitlab::UsageDataCounters::CycleAnalyticsCounter).to receive(:count).with(:views)
get(:show,
params: {
namespace_id: project.namespace,
project_id: project
})
expect(response).to be_successful
end
end
describe 'cycle analytics not set up flag' do
context 'with no data' do
it 'is true' do
get(:show,
params: {
namespace_id: project.namespace,
project_id: project
})
expect(response).to be_successful
expect(assigns(:cycle_analytics_no_data)).to eq(true)
end
end
context 'with data' do
before do
issue = create(:issue, project: project, created_at: 4.days.ago)
milestone = create(:milestone, project: project, created_at: 5.days.ago)
issue.update(milestone: milestone)
create_merge_request_closing_issue(user, project, issue)
end
it 'is false' do
get(:show,
params: {
namespace_id: project.namespace,
project_id: project
})
expect(response).to be_successful
expect(assigns(:cycle_analytics_no_data)).to eq(false)
end
end
end
end