8d1e97fc3b
- Fix `O(n)` complexity of `append_or_update_attribute`, we append objects to an array and re-save project - Remove the usage of `keys.include?` as it performs `O(n)` search, instead use `.has_key?` - Remove the usage of `.keys.first` as it performs a copy of all keys, instead use `.first.first`
51 lines
1.2 KiB
Ruby
51 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe UserCalloutsController do
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
describe "POST #create" do
|
|
subject { post :create, params: { feature_name: feature_name }, format: :json }
|
|
|
|
context 'with valid feature name' do
|
|
let(:feature_name) { UserCallout.feature_names.first.first }
|
|
|
|
context 'when callout entry does not exist' do
|
|
it 'creates a callout entry with dismissed state' do
|
|
expect { subject }.to change { UserCallout.count }.by(1)
|
|
end
|
|
|
|
it 'returns success' do
|
|
subject
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
|
|
context 'when callout entry already exists' do
|
|
let!(:callout) { create(:user_callout, feature_name: UserCallout.feature_names.first.first, user: user) }
|
|
|
|
it 'returns success' do
|
|
subject
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with invalid feature name' do
|
|
let(:feature_name) { 'bogus_feature_name' }
|
|
|
|
it 'returns bad request' do
|
|
subject
|
|
|
|
expect(response).to have_gitlab_http_status(:bad_request)
|
|
end
|
|
end
|
|
end
|
|
end
|