f2d50af917
Previously, we stored these as serialised fields - `st_{commits,diffs}` - on the
`merge_request_diffs` table. These now have their own tables -
`merge_request_diff_{commits,diffs}` - with a column for each attribute of the
serialised data.
Add a background migration to go through the existing MR diffs and migrate them
to the new format. Ignore any contents that cannot be displayed. Assuming that
we have 5 million rows to migrate, and each batch of 2,500 rows can be
completed in 5 minutes, this will take about 7 days to migrate everything.
59 lines
2.1 KiB
Ruby
59 lines
2.1 KiB
Ruby
require 'spec_helper'
|
|
require Rails.root.join('db', 'post_migrate', '20170703130158_schedule_merge_request_diff_migrations')
|
|
|
|
describe ScheduleMergeRequestDiffMigrations, :migration, :sidekiq do
|
|
matcher :be_scheduled_migration do |time, *expected|
|
|
match do |migration|
|
|
BackgroundMigrationWorker.jobs.any? do |job|
|
|
job['args'] == [migration, expected] &&
|
|
job['at'].to_i == time.to_i
|
|
end
|
|
end
|
|
|
|
failure_message do |migration|
|
|
"Migration `#{migration}` with args `#{expected.inspect}` not scheduled!"
|
|
end
|
|
end
|
|
|
|
let(:merge_request_diffs) { table(:merge_request_diffs) }
|
|
let(:merge_requests) { table(:merge_requests) }
|
|
let(:projects) { table(:projects) }
|
|
|
|
before do
|
|
stub_const("#{described_class.name}::BATCH_SIZE", 1)
|
|
|
|
projects.create!(id: 1, name: 'gitlab', path: 'gitlab')
|
|
|
|
merge_requests.create!(id: 1, target_project_id: 1, source_project_id: 1, target_branch: 'feature', source_branch: 'master')
|
|
|
|
merge_request_diffs.create!(id: 1, merge_request_id: 1, st_commits: YAML.dump([]), st_diffs: nil)
|
|
merge_request_diffs.create!(id: 2, merge_request_id: 1, st_commits: nil, st_diffs: YAML.dump([]))
|
|
merge_request_diffs.create!(id: 3, merge_request_id: 1, st_commits: nil, st_diffs: nil)
|
|
merge_request_diffs.create!(id: 4, merge_request_id: 1, st_commits: YAML.dump([]), st_diffs: YAML.dump([]))
|
|
end
|
|
|
|
it 'correctly schedules background migrations' do
|
|
Sidekiq::Testing.fake! do
|
|
Timecop.freeze do
|
|
migrate!
|
|
|
|
expect(described_class::MIGRATION).to be_scheduled_migration(5.minutes.from_now, 1, 1)
|
|
expect(described_class::MIGRATION).to be_scheduled_migration(10.minutes.from_now, 2, 2)
|
|
expect(described_class::MIGRATION).to be_scheduled_migration(15.minutes.from_now, 4, 4)
|
|
expect(BackgroundMigrationWorker.jobs.size).to eq 3
|
|
end
|
|
end
|
|
end
|
|
|
|
it 'schedules background migrations' do
|
|
Sidekiq::Testing.inline! do
|
|
non_empty = 'st_commits IS NOT NULL OR st_diffs IS NOT NULL'
|
|
|
|
expect(merge_request_diffs.where(non_empty).count).to eq 3
|
|
|
|
migrate!
|
|
|
|
expect(merge_request_diffs.where(non_empty).count).to eq 0
|
|
end
|
|
end
|
|
end
|